Bug 136217

Summary: [CSS Grid Layout] Limit the size of explicit/implicit grid
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: CSSAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, darin, dino, kling, koivisto, rhodovan.u-szeged
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 136218    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Mac build fixes
none
Patch kling: review+

Description Sergio Villar Senin 2014-08-25 03:27:00 PDT 
New versions of the spec allow us to set a limit for the size of both implicit and explicit grid.

"Implementations may limit the possible size of the explicit grid. If they do, attempting to specify an explicit grid larger than the implementation-defined maximum must instead define an explicit grid of the maximum size. Implementations may cap the explicit grid to slightly less than the maximum, in order to have only whole repetitions of the repeat() function. It is recommended that the maximum size of the explicit grid not be smaller than 1 million tracks in each axis."

(there is a similar paragraph for the implicit grid).
Comment 1 Sergio Villar Senin 2014-09-23 07:19:44 PDT 
*** Bug 136944 has been marked as a duplicate of this bug. ***
Comment 2 Sergio Villar Senin 2014-10-07 06:46:10 PDT 
Created attachment 239410 [details]
Patch
Comment 3 Sergio Villar Senin 2014-10-07 07:26:20 PDT 
Comment on attachment 239410 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239410&action=review

> Source/WebCore/rendering/style/GridCoordinate.h:44
> +const size_t kGridMaxTracks = 1000000;

Note that the usage of size_t is just for convenience and consistency reasons as the rest of the code is using it. Bug 136218 will replace its usage by unsigned.
Comment 4 Sergio Villar Senin 2014-10-09 07:43:51 PDT 
Created attachment 239537 [details]
Patch

Rebased against latest changes in trunk
Comment 5 Sergio Villar Senin 2014-10-10 02:59:55 PDT 
Created attachment 239612 [details]
Patch
Comment 6 Sergio Villar Senin 2014-10-10 10:01:38 PDT 
Created attachment 239634 [details]
Patch
Comment 7 Sergio Villar Senin 2014-10-13 01:58:47 PDT 
Created attachment 239718 [details]
Patch
Comment 8 Sergio Villar Senin 2014-10-13 06:21:03 PDT 
Created attachment 239726 [details]
Mac build fixes
Comment 9 Sergio Villar Senin 2014-10-15 23:55:43 PDT 
Ping reviewers
Comment 10 Sergio Villar Senin 2014-10-17 06:22:33 PDT 
It'd be awesome to get a review here since this is blocking some other changes.
Comment 11 Sergio Villar Senin 2014-10-21 08:52:30 PDT 
Created attachment 240206 [details]
Patch
Comment 12 Sergio Villar Senin 2014-10-23 01:41:40 PDT 
Darin I know you're very busy with tons of other reviews, but it'd be fantastic if you could take a look at this one.
Comment 13 Sergio Villar Senin 2014-10-29 00:23:55 PDT 
Ping reviewers
Comment 14 Sergio Villar Senin 2014-11-03 21:07:52 PST 
Another ping :)
Comment 15 Sergio Villar Senin 2014-11-10 07:38:03 PST 
This patch is almost 1 month old. Would you mind reviewing it please?
Comment 16 Andreas Kling 2014-11-11 00:47:56 PST 
Comment on attachment 240206 [details]
Patch

r=me. Nice touch converting it to an API test. :)
Comment 17 Sergio Villar Senin 2014-11-11 08:26:14 PST 
Committed r175930: <http://trac.webkit.org/changeset/175930>