| Summary: | TypeProfiler search breaks on return statements | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, fpizlo | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 237094 [details]
patch
Fixes TypeProfiler search.
Created attachment 237130 [details]
patch
Patch can now be applied to ToT
Comment on attachment 237130 [details]
patch
r=me
Comment on attachment 237130 [details] patch Clearing flags on attachment: 237130 Committed r172950: <http://trac.webkit.org/changeset/172950> All reviewed patches have been landed. Closing bug. |
Currently, searching for all TypeLocations in TypeProfiler breaks when looking for an actual return statement in the source text of a function. This breaks because we ask that the search descriptor be a function return statement, but this descriptor should be a function return statement only when we ask for the global return statement of a function (i.e the merged types of all return statements), not when we are asking for the type information for an actual return statement in the source code of a function. i.e: function foo() { return bar }; when asking for type information for "return bar", we should not require the search descriptor to be `function return descriptor`.