Summary: | [CMAKE] Build warning by INTERFACE_LINK_LIBRARIES | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||||
Component: | Tools / Tests | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bunhere, cdumez, commit-queue, dbates, gyuyoung.kim, mrobinson, ossy, rakuco, sergio | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 140497 | ||||||||||
Attachments: |
|
Description
Gyuyoung Kim
2014-08-22 23:17:01 PDT
Created attachment 237041 [details]
Patch
Created attachment 237042 [details]
Patch
r110024 set the INTERFACE_LINK_LIBRARIES manually because there were build break on major linux distro. However, it was two years ago. It looks we can use it on top level CMakeLists.txt again. Created attachment 237193 [details]
Patch
Anyone take a look this patch ? Comment on attachment 237193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237193&action=review rs=me > Source/JavaScriptCore/ChangeLog:8 > + Set the LINK_INTERFACE_LIBRARIES target property on the tol level CMakeLists.txt. typo: tol -> top > Source/WebCore/ChangeLog:8 > + Set the LINK_INTERFACE_LIBRARIES target property on the top level CMakeLists.txt. ditto > Source/WebKit2/ChangeLog:8 > + Set the LINK_INTERFACE_LIBRARIES target property on the top level CMakeLists.txt. ditto > ChangeLog:8 > + Set the LINK_INTERFACE_LIBRARIES target property on the tol level CMakeLists.txt. ditto There are only two "tol" typo, not four. :) Committed r173155: <http://trac.webkit.org/changeset/173155> (In reply to comment #7) > There are only two "tol" typo, not four. :) Thanks Ossy ;) Landed after fixing those nits. |