Bug 136163

Summary: [iOS] Cleanup media code
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, darin, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch. none

Eric Carlson
Reported 2014-08-22 11:14:44 PDT
Remove some unused code.
Attachments
Proposed patch. (7.36 KB, patch)
2014-08-22 11:26 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2014-08-22 11:26:41 PDT
Created attachment 236994 [details] Proposed patch.
Darin Adler
Comment 2 2014-08-22 11:30:21 PDT
Comment on attachment 236994 [details] Proposed patch. parseMediaPlayerAttribute doesn’t look like dead code; there’s a call to it. What makes it actually dead?
Eric Carlson
Comment 3 2014-08-22 11:39:04 PDT
(In reply to comment #2) > (From update of attachment 236994 [details]) > parseMediaPlayerAttribute doesn’t look like dead code; there’s a call to it. Not any more :-) > What makes it actually dead? It calls iOS-only MediaPlayer methods that we no longer implement.
Darin Adler
Comment 4 2014-08-22 11:42:24 PDT
Comment on attachment 236994 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=236994&action=review > Source/WebCore/platform/graphics/MediaPlayerPrivate.h:-243 > - virtual void attributeChanged(const String&, const String&) { } > - virtual bool readyForPlayback() const { return true; } I get it; these calls do nothing so we don’t need all the other levels just to get here.
WebKit Commit Bot
Comment 5 2014-08-22 13:10:34 PDT
Comment on attachment 236994 [details] Proposed patch. Clearing flags on attachment: 236994 Committed r172868: <http://trac.webkit.org/changeset/172868>
WebKit Commit Bot
Comment 6 2014-08-22 13:10:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.