Summary: | [iOS] Cleanup media code | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | calvaris, commit-queue, darin, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, sergio | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Eric Carlson
2014-08-22 11:14:44 PDT
Created attachment 236994 [details]
Proposed patch.
Comment on attachment 236994 [details]
Proposed patch.
parseMediaPlayerAttribute doesn’t look like dead code; there’s a call to it. What makes it actually dead?
(In reply to comment #2) > (From update of attachment 236994 [details]) > parseMediaPlayerAttribute doesn’t look like dead code; there’s a call to it. Not any more :-) > What makes it actually dead? It calls iOS-only MediaPlayer methods that we no longer implement. Comment on attachment 236994 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=236994&action=review > Source/WebCore/platform/graphics/MediaPlayerPrivate.h:-243 > - virtual void attributeChanged(const String&, const String&) { } > - virtual bool readyForPlayback() const { return true; } I get it; these calls do nothing so we don’t need all the other levels just to get here. Comment on attachment 236994 [details] Proposed patch. Clearing flags on attachment: 236994 Committed r172868: <http://trac.webkit.org/changeset/172868> All reviewed patches have been landed. Closing bug. |