[iOS] Cleanup media code

[Eric Carlson]

Remove some unused code.

[Eric Carlson]

Created attachment 236994 [details]
Proposed patch.

[Darin Adler]

Comment on attachment 236994 [details]
Proposed patch.

parseMediaPlayerAttribute doesn’t look like dead code; there’s a call to it. What makes it actually dead?

[Eric Carlson]

(In reply to comment #2)
> (From update of attachment 236994 [details])
> parseMediaPlayerAttribute doesn’t look like dead code; there’s a call to it.

Not any more :-)

> What makes it actually dead?

It calls iOS-only MediaPlayer methods that we no longer implement.

[Darin Adler]

Comment on attachment 236994 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=236994&action=review

> Source/WebCore/platform/graphics/MediaPlayerPrivate.h:-243
> -    virtual void attributeChanged(const String&, const String&) { }
> -    virtual bool readyForPlayback() const { return true; }

I get it; these calls do nothing so we don’t need all the other levels just to get here.

[WebKit Commit Bot]

Comment on attachment 236994 [details]
Proposed patch.

Clearing flags on attachment: 236994

Committed r172868: <http://trac.webkit.org/changeset/172868>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.