Bug 136156

Summary:

[EFL] Enable WebP support.

Product:

WebKit

Reporter:

KwangHyuk <hyuki.kim>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, bunhere, cmarcelo, commit-queue, gyuyoung.kim, l.krok, lucas.de.marchi, rakuco, ryuan.choi, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Linux

Attachments:

Description	Flags
Patch	none
Patch.	none
Patch to get re-screening by wk2-efl ews.	none
Patch,	none
Rebased	none
patch rebased.	none
Patch	none
Patch	none

KwangHyuk

Reported 2014-08-22 07:16:24 PDT

Enable WebP support for the WK2 Efl port.

Attachments
Patch (2.96 KB, patch) 2014-08-22 07:27 PDT, KwangHyuk	no flags	Details Formatted Diff Diff
Patch. (3.93 KB, patch) 2014-08-22 08:59 PDT, KwangHyuk	no flags	Details Formatted Diff Diff
Patch to get re-screening by wk2-efl ews. (4.01 KB, patch) 2014-08-22 22:52 PDT, KwangHyuk	no flags	Details Formatted Diff Diff
Patch, (4.01 KB, patch) 2014-08-22 23:02 PDT, KwangHyuk	no flags	Details Formatted Diff Diff
Rebased (3.98 KB, patch) 2014-10-09 12:46 PDT, KwangHyuk	no flags	Details Formatted Diff Diff
patch rebased. (3.92 KB, patch) 2014-10-10 10:27 PDT, KwangHyuk	no flags	Details Formatted Diff Diff
Patch (6.13 KB, patch) 2014-10-11 06:15 PDT, KwangHyuk	no flags	Details Formatted Diff Diff
Patch (6.63 KB, patch) 2014-10-11 07:03 PDT, KwangHyuk	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

KwangHyuk

Comment 1 2014-08-22 07:27:44 PDT

Created attachment 236985 [details] Patch

KwangHyuk

Comment 2 2014-08-22 08:59:07 PDT

Created attachment 236986 [details] Patch. Additionally, include libwebp-dev as pre-installed package for WK2 Efl.

Gyuyoung Kim

Comment 3 2014-08-22 20:57:20 PDT

Comment on attachment 236986 [details] Patch. Any tests which can be unskipped by this patch ? I just installed libwebp-dev to efl-ews and buildbot. Could you upload a patch again for efl-ews ?

KwangHyuk

Comment 4 2014-08-22 22:52:18 PDT

Created attachment 237027 [details] Patch to get re-screening by wk2-efl ews.

KwangHyuk

Comment 5 2014-08-22 22:53:49 PDT

(In reply to comment #3) > (From update of attachment 236986 [details]) > Any tests which can be unskipped by this patch ? > Good idea. I will check it soon. :) > I just installed libwebp-dev to efl-ews and buildbot. Could you upload a patch again for efl-ews ? Ok, patch was newly applied.

Gyuyoung Kim

Comment 6 2014-08-22 22:56:13 PDT

Comment on attachment 237027 [details] Patch to get re-screening by wk2-efl ews. View in context: https://bugs.webkit.org/attachment.cgi?id=237027&action=review > Source/WTF/wtf/Platform.h:450 > +#if PLATFORM(GTK) || PLATFORM(EFL) If you add this macro, you enable USE(GLIB) as well. It means you enable GTK specific codes as well !! For instance, #if USE(GLIB) typedef struct _GFileIOStream GFileIOStream; typedef struct _GModule GModule; #endif

KwangHyuk

Comment 7 2014-08-22 23:02:39 PDT

Created attachment 237028 [details] Patch,

KwangHyuk

Comment 8 2014-08-22 23:04:02 PDT

(In reply to comment #6) > (From update of attachment 237027 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=237027&action=review > > > Source/WTF/wtf/Platform.h:450 > > +#if PLATFORM(GTK) || PLATFORM(EFL) > > If you add this macro, you enable USE(GLIB) as well. It means you enable GTK specific codes as well !! > > For instance, > > #if USE(GLIB) > typedef struct _GFileIOStream GFileIOStream; > typedef struct _GModule GModule; > #endif Thank you for your correction. :) Patch was newly updated.

KwangHyuk

Comment 9 2014-10-09 12:46:33 PDT

Created attachment 239560 [details] Rebased

Gyuyoung Kim

Comment 10 2014-10-09 17:19:47 PDT

I just installed libwebp-dev to EFL buildbot and ews. Please upload your patch again for efl ews.

KwangHyuk

Comment 11 2014-10-10 10:27:52 PDT

Created attachment 239636 [details] patch rebased.

Gyuyoung Kim

Comment 12 2014-10-10 22:17:31 PDT

Can't we unskip below webp tests on EFL port ? # Requires WebP support. Bug(EFL) fast/canvas/canvas-toDataURL-webp.html Bug(EFL) fast/images/webp-image-decoding.html Bug(EFL) fast/images/webp-color-profile-lossless.html Bug(EFL) fast/images/webp-color-profile-lossy-alpha.html Bug(EFL) fast/images/webp-color-profile-lossy.html Bug(EFL) http/tests/images/webp-partial-load.html Bug(EFL) http/tests/images/webp-progressive-load.html

KwangHyuk

Comment 13 2014-10-11 05:46:29 PDT

(In reply to comment #12) > Can't we unskip below webp tests on EFL port ? > > # Requires WebP support. > Bug(EFL) fast/canvas/canvas-toDataURL-webp.html > Bug(EFL) fast/images/webp-image-decoding.html > Bug(EFL) fast/images/webp-color-profile-lossless.html > Bug(EFL) fast/images/webp-color-profile-lossy-alpha.html > Bug(EFL) fast/images/webp-color-profile-lossy.html > Bug(EFL) http/tests/images/webp-partial-load.html > Bug(EFL) http/tests/images/webp-progressive-load.html IMO, other test can be enabled except fast/canvas/canvas-toDataURL-webp.html. Canvas test needs investigation. :)

KwangHyuk

Comment 14 2014-10-11 06:15:26 PDT

Created attachment 239674 [details] Patch

KwangHyuk

Comment 15 2014-10-11 07:03:59 PDT

Created attachment 239676 [details] Patch

Gyuyoung Kim

Comment 16 2014-10-11 08:46:07 PDT

Comment on attachment 239676 [details] Patch LGTM

WebKit Commit Bot

Comment 17 2014-10-11 09:22:35 PDT

Comment on attachment 239676 [details] Patch Clearing flags on attachment: 239676 Committed r174633: <http://trac.webkit.org/changeset/174633>