Bug 136126

Summary: WebResourceLoadScheduler class has a public constructor although it is a singleton.
Product: WebKit Reporter: Albert Malewski <a.malewski>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: andersca, ap, dbates, m.leszko, mpakulavelrutka
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Albert Malewski 2014-08-21 02:07:55 PDT 
WebResourceLoadScheduler class is a singleton but has public constructor. Access to constructor needs to be changed from public to protected. There is also need to implement a function that is responsible for returning reference to immortal object.
Comment 1 Albert Malewski 2014-08-25 00:21:14 PDT 
Created attachment 237062 [details]
Patch
Comment 2 Darin Adler 2014-08-25 00:46:08 PDT 
Comment on attachment 237062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237062&action=review

> Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.h:66
> +protected:
> +    WebResourceLoadScheduler();
> +    virtual ~WebResourceLoadScheduler();

Why protected instead of private?
Comment 3 Darin Adler 2014-08-25 00:46:40 PDT 
Comment on attachment 237062 [details]
Patch

This doesn’t seem like a great change. It’s OK, but not a significant improvement.
Comment 4 Albert Malewski 2014-08-25 01:05:33 PDT 
This patch is a result of discussion from: https://bugs.webkit.org/show_bug.cgi?id=136038
Comment 5 Daniel Bates 2016-04-25 20:24:43 PDT 
Comment on attachment 237062 [details]
Patch

This patch is stale and needs to be rebased. The class WebResourceLoadScheduler was renamed to WebLoaderStrategy in <http://trac.webkit.org/changeset/193468> (bug #151854).
Comment 6 Michael Catanzaro 2016-09-17 07:09:43 PDT 
Comment on attachment 237062 [details]
Patch

Hi,

Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting.

To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.