Bug 136105

Summary: [Win] JavaScriptCore.dll is missing version information
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: JavaScriptCoreAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Blocker CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch dino: review+

Description Brent Fulgham 2014-08-20 09:26:32 PDT 
The JavaScriptCore.dll is missing the version information specified in the sources. This patch corrects the missing step needed to seed the version resource for the build.
Comment 1 Brent Fulgham 2014-08-20 09:26:52 PDT 
<rdar://problem/18075852>
Comment 2 Brent Fulgham 2014-08-20 09:31:21 PDT 
It looks like the JavaScriptCorePreBuild.cmd is missing a call to auto-version.pl to seed the JSC-specific build directory with the version information.
Comment 3 Brent Fulgham 2014-08-20 10:56:02 PDT 
Created attachment 236881 [details]
Patch
Comment 4 Brent Fulgham 2014-08-20 12:47:03 PDT 
Committed r172805: <http://trac.webkit.org/changeset/172805>