Bug 136105

Summary: [Win] JavaScriptCore.dll is missing version information
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: JavaScriptCoreAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Blocker CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch dino: review+

Brent Fulgham
Reported 2014-08-20 09:26:32 PDT
The JavaScriptCore.dll is missing the version information specified in the sources. This patch corrects the missing step needed to seed the version resource for the build.
Attachments
Patch (1.38 KB, patch)
2014-08-20 10:56 PDT, Brent Fulgham 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-08-20 09:26:52 PDT
<rdar://problem/18075852>
Brent Fulgham
Comment 2 2014-08-20 09:31:21 PDT
It looks like the JavaScriptCorePreBuild.cmd is missing a call to auto-version.pl to seed the JSC-specific build directory with the version information.
Brent Fulgham
Comment 3 2014-08-20 10:56:02 PDT
Created attachment 236881 [details] Patch
Brent Fulgham
Comment 4 2014-08-20 12:47:03 PDT
Committed r172805: <http://trac.webkit.org/changeset/172805>
Note You need to log in before you can comment on or make changes to this bug.