Summary: | [EFL] Apply 'direct' option to accelerated compositing for rendering directly to evas' window. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hyowon Kim <hw1008.kim> | ||||||
Component: | WebKit EFL | Assignee: | Hyowon Kim <hw1008.kim> | ||||||
Status: | RESOLVED WONTFIX | ||||||||
Severity: | Normal | CC: | bunhere, cdumez, cmarcelo, commit-queue, darin, gyuyoung.kim, kondapallykalyan, lucas.de.marchi, luiz, mcatanzaro, noam, ryuan.choi, sergio | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Hyowon Kim
2014-08-19 22:42:00 PDT
Created attachment 236854 [details]
Patch
Comment on attachment 236854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236854&action=review > Source/WebCore/ChangeLog:3 > + Apply 'direct' option to accelerated compositing for rendering directly to evas' window. Let's add [EFL] prefix > Source/WebKit2/UIProcess/API/efl/EwkView.cpp:578 > + return; Looks unnecessary Comment on attachment 236854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236854&action=review > Source/WebCore/ChangeLog:18 > + * platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp: > + (WebCore::CoordinatedGraphicsScene::CoordinatedGraphicsScene): > + (WebCore::CoordinatedGraphicsScene::updateViewportFired): > + (WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext): I think that you leave the message why you added timer. > Source/WebKit2/UIProcess/API/efl/EwkView.cpp:591 > + else { > + if (!m_displayTimer.isActive()) > + m_displayTimer.startOneShot(0); > + } Let's simply this. hyowon, when you can update this? Comment on attachment 236854 [details] Patch Cleared review? from attachment 236854 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug or this bug again. Hyowon, Do you have plan to update this? If not, I will rebase your patch to land it. Created attachment 255183 [details]
Patch
Comment on attachment 255183 [details]
Patch
Ryaun, this patch is still valid ?
Comment on attachment 255183 [details]
Patch
IMO, this is valid but should be rebased.
So, cleared r? flag.
Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this. |