Summary: | Add animationDidEnd callbacks on GraphicsLayer | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan, sergio, simon.fraser | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2014-08-19 15:54:23 PDT
Created attachment 236830 [details]
Patch
Comment on attachment 236830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236830&action=review > Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:352 > +void PlatformCALayerMac::animationStarted(const String& animtionKey, CFTimeInterval beginTime) anim*a*tion > Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:137 > + auto it = m_layersWithAnimations.find(layerID); should we not remove the layer from m_layersWithAnimations if it doesn't have any more animations? Created attachment 236837 [details]
Patch
|