Bug 136084

Summary: Add animationDidEnd callbacks on GraphicsLayer
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, sergio, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Simon Fraser (smfr)
Reported 2014-08-19 15:54:23 PDT
Add animationDidEnd callbacks on GraphicsLayer
Attachments
Patch (27.65 KB, patch)
2014-08-19 15:56 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (29.74 KB, patch)
2014-08-19 17:29 PDT, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2014-08-19 15:56:50 PDT
Created attachment 236830 [details] Patch
Tim Horton
Comment 2 2014-08-19 16:01:13 PDT
Comment on attachment 236830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236830&action=review > Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:352 > +void PlatformCALayerMac::animationStarted(const String& animtionKey, CFTimeInterval beginTime) anim*a*tion > Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:137 > + auto it = m_layersWithAnimations.find(layerID); should we not remove the layer from m_layersWithAnimations if it doesn't have any more animations?
Simon Fraser (smfr)
Comment 3 2014-08-19 17:29:51 PDT
Created attachment 236837 [details] Patch
Simon Fraser (smfr)
Comment 4 2014-08-21 15:44:08 PDT
https://trac.webkit.org/r172836
Note You need to log in before you can comment on or make changes to this bug.