Bug 136083

Summary: Fix indentation and style in LowLevelInterpreter.asm
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch mark.lam: review+

Filip Pizlo
Reported 2014-08-19 15:10:30 PDT
If/then/else statements in offlineasm are not preprocessor macros. Their contents should be indented appropriately. Also "not" is a thing so there is no need to do weird things like "if <blah>\nelse" when you could do "if not <blah>".
Attachments
the patch (10.24 KB, patch)
2014-08-19 15:12 PDT, Filip Pizlo 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2014-08-19 15:11:44 PDT
(In reply to comment #0) > Also "not" is a thing so there is no need to do weird things like "if <blah>\nelse" when you could do "if not <blah>". Nice. I didn’t know about that.
Filip Pizlo
Comment 2 2014-08-19 15:12:22 PDT
Created attachment 236827 [details] the patch
Mark Lam
Comment 3 2014-08-19 15:14:36 PDT
Comment on attachment 236827 [details] the patch r=me
Filip Pizlo
Comment 4 2014-08-19 15:26:04 PDT
Landed in http://trac.webkit.org/changeset/172767
Note You need to log in before you can comment on or make changes to this bug.