Bug 136083

Summary:

Fix indentation and style in LowLevelInterpreter.asm

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	mark.lam: review+

Description Filip Pizlo 2014-08-19 15:10:30 PDT

If/then/else statements in offlineasm are not preprocessor macros.  Their contents should be indented appropriately.  Also "not" is a thing so there is no need to do weird things like "if <blah>\nelse" when you could do "if not <blah>".

Comment 1 Mark Lam 2014-08-19 15:11:44 PDT

(In reply to comment #0)
> Also "not" is a thing so there is no need to do weird things like "if <blah>\nelse" when you could do "if not <blah>".

Nice.  I didn’t know about that.

Comment 2 Filip Pizlo 2014-08-19 15:12:22 PDT

Created attachment 236827 [details]
the patch

Comment 3 Mark Lam 2014-08-19 15:14:36 PDT

Comment on attachment 236827 [details]
the patch

r=me

Comment 4 Filip Pizlo 2014-08-19 15:26:04 PDT

Landed in http://trac.webkit.org/changeset/172767