Bug 136068 – JSC_timeout is hard-coded in run-javascriptcore-test

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Akos Kiss]

Currently, the value of the JSC_timeout environment variable is unconditionally set to 60 (seconds). On some platforms, that's overly restrictive since the running time of some jsc tests can exceed 60 seconds (not because of hanging, just running slowly). The caller of run-javascriptcore-tests should be able to increase/set this timeout value to get valid results.

[Akos Kiss]

Created attachment 236808 [details]
Proposed patch.

This patch allows changing the timeout for jsc tests by defining JSC_timeout in advance, e.g., as follows:
JSC_timeout=120 Tools/Scripts/run-javascriptcore-tests

[Csaba Osztrogonác]

Comment on attachment 236808 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=236808&action=review

> Tools/Scripts/run-javascriptcore-tests:151
> +$ENV{JSC_timeout} = 60 if (!defined($ENV{JSC_timeout})); # Set a 60 second timeout on all jsc tests (if environment variable not defined already).

I think we can do it in a simpler way:
$ENV{JSC_timeout} = 60 unless $ENV{JSC_timeout};

[Akos Kiss]

Created attachment 236810 [details]
Proposed patch, v2

Made the change more perlish, according to the review.

[Csaba Osztrogonác]

Comment on attachment 236810 [details]
Proposed patch, v2

LGTM

[WebKit Commit Bot]

Comment on attachment 236810 [details]
Proposed patch, v2

Clearing flags on attachment: 236810

Committed r172751: <http://trac.webkit.org/changeset/172751>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.