Bug 13606

Summary: some functions are virtual that don't need to be
Product: WebKit Reporter: Darin Adler <darin>
Component: DOMAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Enhancement CC: cdumez
Priority: P4    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch
none
patch with change log hyatt: review+

Darin Adler
Reported 2007-05-06 16:36:21 PDT
I spotted some functions that definitely don't need to be virtual. I think firstChild and lastChild are pretty big wins -- there's a way for them to be virtual in Node, but non-virtual in classes like Element.
Attachments
patch (9.24 KB, patch)
2007-05-06 16:45 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
patch with change log (12.14 KB, patch)
2007-05-06 16:48 PDT, Darin Adler 		hyatt: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2007-05-06 16:45:41 PDT
Created attachment 14379 [details] patch
Darin Adler
Comment 2 2007-05-06 16:48:12 PDT
Created attachment 14380 [details] patch with change log
Dave Hyatt
Comment 3 2007-05-06 19:27:57 PDT
Comment on attachment 14380 [details] patch with change log r=me
Darin Adler
Comment 4 2007-05-06 20:18:17 PDT
Committed revision 21278.
Lucas Forschler
Comment 5 2019-02-06 09:02:53 PST
Mass moving XML DOM bugs to the "DOM" Component.
Note You need to log in before you can comment on or make changes to this bug.