Bug 13606 - some functions are virtual that don't need to be
Summary: some functions are virtual that don't need to be
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P4 Enhancement
Assignee: Darin Adler
Depends on:
Reported: 2007-05-06 16:36 PDT by Darin Adler
Modified: 2019-02-06 09:02 PST (History)
1 user (show)

See Also:

patch (9.24 KB, patch)
2007-05-06 16:45 PDT, Darin Adler
no flags Details | Formatted Diff | Diff
patch with change log (12.14 KB, patch)
2007-05-06 16:48 PDT, Darin Adler
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2007-05-06 16:36:21 PDT
I spotted some functions that definitely don't need to be virtual. I think firstChild and lastChild are pretty big wins -- there's a way for them to be virtual in Node, but non-virtual in classes like Element.
Comment 1 Darin Adler 2007-05-06 16:45:41 PDT
Created attachment 14379 [details]
Comment 2 Darin Adler 2007-05-06 16:48:12 PDT
Created attachment 14380 [details]
patch with change log
Comment 3 Dave Hyatt 2007-05-06 19:27:57 PDT
Comment on attachment 14380 [details]
patch with change log

Comment 4 Darin Adler 2007-05-06 20:18:17 PDT
Committed revision 21278.
Comment 5 Lucas Forschler 2019-02-06 09:02:53 PST
Mass moving XML DOM bugs to the "DOM" Component.