Bug 136052

Summary: Stop using pseudo-aware traversal in RenderListItem
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Antti Koivisto
Reported 2014-08-18 16:51:14 PDT
Normal traversal works fine.
Attachments
patch (5.98 KB, patch)
2014-08-18 16:58 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2014-08-18 16:58:01 PDT
Created attachment 236790 [details] patch
Darin Adler
Comment 2 2014-08-18 17:15:33 PDT
Comment on attachment 236790 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=236790&action=review > Source/WebCore/rendering/RenderListItem.cpp:-138 > - // FIXME: Can this be optimized to skip the children of the elements without a renderer? So I guess you are removing this because the answer is no?
Antti Koivisto
Comment 3 2014-08-18 17:34:00 PDT
> > - // FIXME: Can this be optimized to skip the children of the elements without a renderer? > > So I guess you are removing this because the answer is no? It could, it just didn't feel important enough for a FIXME. We should really have abstraction for "traverse render tree in DOM order" which would do optimisations like that.
Antti Koivisto
Comment 4 2014-08-18 17:50:35 PDT
This is actually wrong, a pseudo element can have display:list-item.
Note You need to log in before you can comment on or make changes to this bug.