| Summary: | Stop using pseudo-aware traversal in RenderListItem | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED INVALID | ||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antti Koivisto
2014-08-18 16:51:14 PDT
Created attachment 236790 [details]
patch
Comment on attachment 236790 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=236790&action=review > Source/WebCore/rendering/RenderListItem.cpp:-138 > - // FIXME: Can this be optimized to skip the children of the elements without a renderer? So I guess you are removing this because the answer is no? > > - // FIXME: Can this be optimized to skip the children of the elements without a renderer?
>
> So I guess you are removing this because the answer is no?
It could, it just didn't feel important enough for a FIXME.
We should really have abstraction for "traverse render tree in DOM order" which would do optimisations like that.
This is actually wrong, a pseudo element can have display:list-item. |