Bug 136049

Summary: Tighten RenderCounter typing
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch kling: review+

Antti Koivisto
Reported 2014-08-18 14:25:05 PDT
yep
Attachments
patch (35.75 KB, patch)
2014-08-18 14:31 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2014-08-18 14:31:24 PDT
Created attachment 236785 [details] patch
WebKit Commit Bot
Comment 2 2014-08-18 14:32:47 PDT
Attachment 236785 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderElement.h:237: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 3 2014-08-18 14:40:34 PDT
Comment on attachment 236785 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=236785&action=review > Source/WebCore/rendering/RenderCounter.cpp:294 > // Real text nodes don't have their own style so they can't have counters. > // We can't even look at their styles or we'll see extra resets and increments! > - if (object->isText()) > - return nullptr; > Should delete this comment. It no longer applies.
Antti Koivisto
Comment 4 2014-08-18 15:18:44 PDT
https://trac.webkit.org/r172730
Note You need to log in before you can comment on or make changes to this bug.