Bug 136049 - Tighten RenderCounter typing
Summary: Tighten RenderCounter typing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-18 14:25 PDT by Antti Koivisto
Modified: 2014-08-18 15:18 PDT (History)
4 users (show)

See Also:

Attachments
patch (35.75 KB, patch)
2014-08-18 14:31 PDT, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-08-18 14:25:05 PDT 
yep
Comment 1 Antti Koivisto 2014-08-18 14:31:24 PDT 
Created attachment 236785 [details]
patch
Comment 2 WebKit Commit Bot 2014-08-18 14:32:47 PDT 
Attachment 236785 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderElement.h:237:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2014-08-18 14:40:34 PDT 
Comment on attachment 236785 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236785&action=review

> Source/WebCore/rendering/RenderCounter.cpp:294
>      // Real text nodes don't have their own style so they can't have counters.
>      // We can't even look at their styles or we'll see extra resets and increments!
> -    if (object->isText())
> -        return nullptr;
>  

Should delete this comment. It no longer applies.
Comment 4 Antti Koivisto 2014-08-18 15:18:44 PDT 
https://trac.webkit.org/r172730