Expose long mouse press WebKit API. Part of 135257 - Add long mouse press gesture

• Component: UI Events
• Status: RESOLVED FIXED

[Peyton Randolph]

It would be convenient to have callbacks in the injected bundle and client for the long mouse press gesture.

[Peyton Randolph]

Created attachment 236782 [details]
Patch

Comment on attachment 236782 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236782&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h:171
> +    WKBundlePageDidBeginTrackingPotentialLongMousePressCallback            didBeginTrackingPotentialLongMousePress;
> +    WKBundlePageDidRecognizeLongMousePressCallback                         didRecognizeLongMousePress;
> +    WKBundlePageDidCancelTrackingPotentialLongMousePressCallback           didCancelTrackingPotentialLongMousePress;

These last three aren’t aligned with all of the above.

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:209
> +    WKTypeRef userDataToPass = 0;

Please use nullptr.

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:219
> +    WKTypeRef userDataToPass = 0;

Ditto.

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:229
> +    WKTypeRef userDataToPass = 0;

Ditto.

[Peyton Randolph]

(In reply to comment #2)
> (From update of attachment 236782 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=236782&action=review
> 
> > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h:171
> > +    WKBundlePageDidBeginTrackingPotentialLongMousePressCallback            didBeginTrackingPotentialLongMousePress;
> > +    WKBundlePageDidRecognizeLongMousePressCallback                         didRecognizeLongMousePress;
> > +    WKBundlePageDidCancelTrackingPotentialLongMousePressCallback           didCancelTrackingPotentialLongMousePress;
> 
> These last three aren’t aligned with all of the above.

Aligned.
> 
> > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:209
> > +    WKTypeRef userDataToPass = 0;
> 
> Please use nullptr.

Fixed.

> 
> > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:219
> > +    WKTypeRef userDataToPass = 0;
> 
> Ditto.

Fixed.
> 
> > Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:229
> > +    WKTypeRef userDataToPass = 0;
> 
> Ditto.

Fixed.

[Peyton Randolph]

Created attachment 236784 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 236784 [details]
Patch

Clearing flags on attachment: 236784

Committed r172729: <http://trac.webkit.org/changeset/172729>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.