| Summary: | REGRESSION (r168244): Content in horizontal-bt page is offset such that only the end is viewable and there is a white gap at the top | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | mitz | ||||||
| Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bdakin, cmarcelo, commit-queue, esprehn+autocc, glenn, jamesr, kondapallykalyan, luiz, simon.fraser, thorton, tonikitoo | ||||||
| Priority: | P1 | Keywords: | InRadar, Regression | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Caused by http://trac.webkit.org/r168244, the fix for bug 132535. Fixed, probably in https://trac.webkit.org/changeset/194487. Not fixed. The bug is that RLC sets the correct position of the root content layer at:
m_rootContentLayer->setPosition(FloatPoint(documentRect.x(), documentRect.y() + m_renderView.frameView().yPositionForRootContentLayer()));
but the scrolling thread overwrite that with a bad position at:
m_scrolledContentsLayer.get().position = FloatPoint(m_scrolledContentsLayer.get().position.x,
FrameView::yPositionForRootContentLayer(position, topContentInset, headerHeight()));
which ignores the documentRect part.
Created attachment 269547 [details]
Patch
|
Created attachment 236717 [details] Test case To reproduce the bug, open the test case in Safari. The content is pushed down such that there is a white gap at the top and only the top (end) of the content is visible.