| Summary: | [EME][Mac] Refactor CDMPrivateMediaSourceAVFObjC to allow sessions to be created without being attached to an AVStreamDataParser. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | calvaris, commit-queue, eric.carlson, glenn, ltilve, philipj, sergio | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jer Noble
2014-08-16 00:04:56 PDT
Created attachment 236704 [details]
WIP
Created attachment 236776 [details]
Patch
Comment on attachment 236776 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236776&action=review > Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:61 > + return MediaPlayerPrivateMediaSourceAVFObjC::supportsType(parameters); Nit: MediaPlayerPrivateMediaSourceAVFObjC::supportsType returns MediaPlayer::SupportsType, not bool. > Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:73 > + return MediaPlayerPrivateMediaSourceAVFObjC::supportsType(parameters); Ditto. Created attachment 236821 [details]
Patch for landing
Comment on attachment 236821 [details]
Patch for landing
EFL build failures are due to an internal compiler error. Marking as cq+.
Comment on attachment 236821 [details] Patch for landing Clearing flags on attachment: 236821 Committed r173197: <http://trac.webkit.org/changeset/173197> |