Bug 136016

Summary: [EME][Mac] Refactor CDMPrivateMediaSourceAVFObjC to allow sessions to be created without being attached to an AVStreamDataParser.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, eric.carlson, glenn, ltilve, philipj, sergio
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
Patch
eric.carlson: review+
Patch for landing none

Jer Noble
Reported 2014-08-16 00:04:56 PDT
[EME][Mac] Refactor CDMPrivateMediaSourceAVFObjC to allow sessions to be created without being attached to an AVStreamDataParser.
Attachments
WIP (37.46 KB, patch)
2014-08-16 00:06 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (38.66 KB, patch)
2014-08-18 12:25 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (38.83 KB, patch)
2014-08-19 12:51 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2014-08-16 00:06:45 PDT
Created attachment 236704 [details] WIP
Jer Noble
Comment 2 2014-08-18 12:25:27 PDT
Created attachment 236776 [details] Patch
Eric Carlson
Comment 3 2014-08-18 13:16:36 PDT
Comment on attachment 236776 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236776&action=review > Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:61 > + return MediaPlayerPrivateMediaSourceAVFObjC::supportsType(parameters); Nit: MediaPlayerPrivateMediaSourceAVFObjC::supportsType returns MediaPlayer::SupportsType, not bool. > Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:73 > + return MediaPlayerPrivateMediaSourceAVFObjC::supportsType(parameters); Ditto.
Jer Noble
Comment 4 2014-08-19 12:51:49 PDT
Created attachment 236821 [details] Patch for landing
Jer Noble
Comment 5 2014-09-02 17:53:58 PDT
Comment on attachment 236821 [details] Patch for landing EFL build failures are due to an internal compiler error. Marking as cq+.
WebKit Commit Bot
Comment 6 2014-09-02 18:28:43 PDT
Comment on attachment 236821 [details] Patch for landing Clearing flags on attachment: 236821 Committed r173197: <http://trac.webkit.org/changeset/173197>
Jer Noble
Comment 7 2014-12-16 13:27:22 PST
<rdar://problem/19269025>
Note You need to log in before you can comment on or make changes to this bug.