Bug 136016 - [EME][Mac] Refactor CDMPrivateMediaSourceAVFObjC to allow sessions to be created without being attached to an AVStreamDataParser.
Summary: [EME][Mac] Refactor CDMPrivateMediaSourceAVFObjC to allow sessions to be crea...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-16 00:04 PDT by Jer Noble
Modified: 2015-01-26 08:49 PST (History)
7 users (show)

See Also:

Attachments
WIP (37.46 KB, patch)
2014-08-16 00:06 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (38.66 KB, patch)
2014-08-18 12:25 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (38.83 KB, patch)
2014-08-19 12:51 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-08-16 00:04:56 PDT 
[EME][Mac] Refactor CDMPrivateMediaSourceAVFObjC to allow sessions to be created without being attached to an AVStreamDataParser.
Comment 1 Jer Noble 2014-08-16 00:06:45 PDT 
Created attachment 236704 [details]
WIP
Comment 2 Jer Noble 2014-08-18 12:25:27 PDT 
Created attachment 236776 [details]
Patch
Comment 3 Eric Carlson 2014-08-18 13:16:36 PDT 
Comment on attachment 236776 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236776&action=review

> Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:61
> +        return MediaPlayerPrivateMediaSourceAVFObjC::supportsType(parameters);

Nit: MediaPlayerPrivateMediaSourceAVFObjC::supportsType returns MediaPlayer::SupportsType, not bool.

> Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:73
> +    return MediaPlayerPrivateMediaSourceAVFObjC::supportsType(parameters);

Ditto.
Comment 4 Jer Noble 2014-08-19 12:51:49 PDT 
Created attachment 236821 [details]
Patch for landing
Comment 5 Jer Noble 2014-09-02 17:53:58 PDT 
Comment on attachment 236821 [details]
Patch for landing

EFL build failures are due to an internal compiler error. Marking as cq+.
Comment 6 WebKit Commit Bot 2014-09-02 18:28:43 PDT 
Comment on attachment 236821 [details]
Patch for landing

Clearing flags on attachment: 236821

Committed r173197: <http://trac.webkit.org/changeset/173197>
Comment 7 Jer Noble 2014-12-16 13:27:22 PST 
<rdar://problem/19269025>