Bug 136011

Summary:

REGRESSION (r164173): Safari AutoFill button in popover, default buttons on iCloud control panel and Safari Safe Browsing pages don't have default appearance

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

Forms

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+

Description Dean Jackson 2014-08-15 18:56:36 PDT

In order to render some controls correctly, the NSWindow subclass we use in ThemeMac.mm should identify itself as the key window (when the WebKit view is key).

<rdar://problem/17577321>

Comment 1 Dean Jackson 2014-08-15 18:59:43 PDT

Created attachment 236698 [details]
Patch

Comment 2 Sam Weinig 2014-08-15 21:08:27 PDT

Can this be tested?

Comment 3 Dean Jackson 2014-08-16 13:28:32 PDT

(In reply to comment #2)
> Can this be tested?

Not that easily. I'll open a bug to expose the chrome mode.

https://bugs.webkit.org/show_bug.cgi?id=136023

Comment 4 Sam Weinig 2014-08-16 13:32:51 PDT

(In reply to comment #3)
> (In reply to comment #2)
> > Can this be tested?
> 
> Not that easily. I'll open a bug to expose the chrome mode.
> 
> https://bugs.webkit.org/show_bug.cgi?id=136023

What makes it hard?

Comment 5 Dean Jackson 2014-08-16 14:21:43 PDT

Committed r172693: <http://trac.webkit.org/changeset/172693>