Bug 136011

Summary: REGRESSION (r164173): Safari AutoFill button in popover, default buttons on iCloud control panel and Safari Safe Browsing pages don't have default appearance
Product: WebKit Reporter: Dean Jackson <dino>
Component: FormsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Dean Jackson
Reported 2014-08-15 18:56:36 PDT
In order to render some controls correctly, the NSWindow subclass we use in ThemeMac.mm should identify itself as the key window (when the WebKit view is key). <rdar://problem/17577321>
Attachments
Patch (1.55 KB, patch)
2014-08-15 18:59 PDT, Dean Jackson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2014-08-15 18:59:43 PDT
Created attachment 236698 [details] Patch
Sam Weinig
Comment 2 2014-08-15 21:08:27 PDT
Can this be tested?
Dean Jackson
Comment 3 2014-08-16 13:28:32 PDT
(In reply to comment #2) > Can this be tested? Not that easily. I'll open a bug to expose the chrome mode. https://bugs.webkit.org/show_bug.cgi?id=136023
Sam Weinig
Comment 4 2014-08-16 13:32:51 PDT
(In reply to comment #3) > (In reply to comment #2) > > Can this be tested? > > Not that easily. I'll open a bug to expose the chrome mode. > > https://bugs.webkit.org/show_bug.cgi?id=136023 What makes it hard?
Dean Jackson
Comment 5 2014-08-16 14:21:43 PDT
Committed r172693: <http://trac.webkit.org/changeset/172693>
Note You need to log in before you can comment on or make changes to this bug.