Bug 136011 - REGRESSION (r164173): Safari AutoFill button in popover, default buttons on iCloud control panel and Safari Safe Browsing pages don't have default appearance
Summary: REGRESSION (r164173): Safari AutoFill button in popover, default buttons on i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-15 18:56 PDT by Dean Jackson
Modified: 2014-08-16 14:21 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.55 KB, patch)
2014-08-15 18:59 PDT, Dean Jackson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2014-08-15 18:56:36 PDT 
In order to render some controls correctly, the NSWindow subclass we use in ThemeMac.mm should identify itself as the key window (when the WebKit view is key).

<rdar://problem/17577321>
Comment 1 Dean Jackson 2014-08-15 18:59:43 PDT 
Created attachment 236698 [details]
Patch
Comment 2 Sam Weinig 2014-08-15 21:08:27 PDT 
Can this be tested?
Comment 3 Dean Jackson 2014-08-16 13:28:32 PDT 
(In reply to comment #2)
> Can this be tested?

Not that easily. I'll open a bug to expose the chrome mode.

https://bugs.webkit.org/show_bug.cgi?id=136023
Comment 4 Sam Weinig 2014-08-16 13:32:51 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > Can this be tested?
> 
> Not that easily. I'll open a bug to expose the chrome mode.
> 
> https://bugs.webkit.org/show_bug.cgi?id=136023

What makes it hard?
Comment 5 Dean Jackson 2014-08-16 14:21:43 PDT 
Committed r172693: <http://trac.webkit.org/changeset/172693>