Bug 136006

Summary: Web Inspector: Update Scripts/update-LegacyInspectorBackendCommands.rb for the new generator
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: burg, commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
timothy: review+
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2014-08-15 16:28:21 PDT
* SUMMARY Update Scripts/update-LegacyInspectorBackendCommands.rb for the new generator * STEPS TO REPRODUCE 1. shell> ./Source/WebInspectorUI/Scripts/update-LegacyInspectorBackendCommands.rb => should work!
Attachments
[PATCH] Proposed Fix (12.15 KB, patch)
2014-08-15 16:29 PDT, Joseph Pecoraro 		timothy: review+
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (13.06 KB, patch)
2014-08-15 18:12 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-08-15 16:28:32 PDT
<rdar://problem/18037494>
Joseph Pecoraro
Comment 2 2014-08-15 16:29:57 PDT
Created attachment 236689 [details] [PATCH] Proposed Fix
Timothy Hatcher
Comment 3 2014-08-15 16:36:13 PDT
Comment on attachment 236689 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=236689&action=review > Source/WebInspectorUI/UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js:76 > +InspectorBackend.registerEnum("Console.ConsoleMessageSource", {HTML: "html", Wml: "wml", XML: "xml", Javascript: "javascript", Network: "network", ConsoleAPI: "console-api", Other: "other"}); Should add WML to the generator.
Joseph Pecoraro
Comment 4 2014-08-15 17:10:45 PDT
Err, or we should just remove it. We don't support it anymore right?
Joseph Pecoraro
Comment 5 2014-08-15 18:12:14 PDT
Created attachment 236696 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 6 2014-08-15 22:49:33 PDT
Comment on attachment 236696 [details] [PATCH] Proposed Fix Clearing flags on attachment: 236696 Committed r172688: <http://trac.webkit.org/changeset/172688>
WebKit Commit Bot
Comment 7 2014-08-15 22:49:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.