Bug 135991

Summary:

Fix plugin visibility check.

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

WebKit2

Assignee:

Gavin Barraclough <barraclough>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fix	kling: review+

Description Gavin Barraclough 2014-08-15 12:49:56 PDT

We should only take a UserActivity if the plugin is in a visible window, and also is itself visible.

Comment 1 Gavin Barraclough 2014-08-15 12:53:38 PDT

Created attachment 236671 [details]
Fix

Comment 2 Andreas Kling 2014-08-15 13:21:31 PDT

Comment on attachment 236671 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=236671&action=review

r=me

> Source/WebKit2/ChangeLog:20
> +            - added m_isVisibile, m_isWindowVisibile, updateVisiblityActivity.

m_isVisibile -> m_isVisible
m_isWindowVisibile -> m_isWindowVisible
updateVisiblityActivity -> updateVisibilityActivity

Comment 3 Gavin Barraclough 2014-08-15 13:32:36 PDT

Transmitting file data ...
Committed revision 172645.

Comment 4 Gavin Barraclough 2014-08-15 13:37:48 PDT

Type fix

Transmitting file data ...
Committed revision 172646.

Comment 5 Gavin Barraclough 2014-08-15 14:22:33 PDT

Transmitting file data ...
Committed revision 172653.