| Summary: | Native library inlining crashes when module isn't found | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Matthew Mirman <mmirman> | ||||
| Component: | JavaScriptCore | Assignee: | Matthew Mirman <mmirman> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, fpizlo, ggaren, mmirman | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Matthew Mirman
2014-08-15 11:44:36 PDT
Created attachment 236663 [details]
fixed native library inlining in the ftl segfaulting
Also abstracts out an "Options::verboseCompilation"
Comment on attachment 236663 [details] fixed native library inlining in the ftl segfaulting View in context: https://bugs.webkit.org/attachment.cgi?id=236663&action=review > Source/JavaScriptCore/ChangeLog:15 > + (JSC::FTL::LowerDFGToLLVM::compilePutById): > + abstracted out Options::verboseCompilation as was the case in the rest of the file. > + (JSC::FTL::LowerDFGToLLVM::compileNativeCallOrConstruct): > + (JSC::FTL::LowerDFGToLLVM::getModuleByPathForSymbol): > + added output error messages for llvm module loading. Best to capitalize these sentences. Comment on attachment 236663 [details] fixed native library inlining in the ftl segfaulting Clearing flags on attachment: 236663 Committed r172648: <http://trac.webkit.org/changeset/172648> All reviewed patches have been landed. Closing bug. |