Bug 135987

Summary:

de-PLATFORM(COCOA) a couple of methods in plugin code

Product:

WebKit

Reporter:

Gavin Barraclough <barraclough>

Component:

WebKit2

Assignee:

Gavin Barraclough <barraclough>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fix	sam: review+

Description Gavin Barraclough 2014-08-15 11:40:45 PDT

Pass through the visibility & focus on all platforms, to simplify & avoid any weird inconsistencies between platforms.

Comment 1 Gavin Barraclough 2014-08-15 11:48:12 PDT

Created attachment 236662 [details]
Fix

Comment 2 Sam Weinig 2014-08-15 11:52:19 PDT

Comment on attachment 236662 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=236662&action=review

> Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:445
> +    m_plugin->windowVisibilityChanged(isVisible);

Add ASSERT to match?

Comment 3 Gavin Barraclough 2014-08-15 11:57:13 PDT

Transmitting file data ............
Committed revision 172637.