| Summary: | Turn r/rx/ry to presentation attributes | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Schulze <krit> | ||||||||
| Component: | SVG | Assignee: | Dirk Schulze <krit> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | dino, zimmermann | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 135045 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Dirk Schulze
2014-08-15 09:29:12 PDT
Created attachment 236650 [details]
Patch
The patch depends on bug 135975 and won't compile until the patch on the bug landed. Created attachment 236660 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 236650 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236650&action=review It seems this has much of the original cx/cy patch in it. Assuming that is removed when the cx/cy lands... r=me > Source/WebCore/ChangeLog:64 > +2014-08-15 Dirk Schulze <krit@webkit.org> > + > + Turn cx/cy to presentation attributes > + https://bugs.webkit.org/show_bug.cgi?id=135975 > + > + Reviewed by NOBODY (OOPS!). > + > + This follows the patch for width and height presentation attributes and > + turns x and y to presentation attributes as well: > + ChangeLog has the previous patch in it as well. > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:408 > + CSSPropertyCx, > + CSSPropertyCy, Oops. > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2977 > + case CSSPropertyCx: > + return zoomAdjustedPixelValueForLength(style->svgStyle().cx(), style.get()); > + case CSSPropertyCy: > + return zoomAdjustedPixelValueForLength(style->svgStyle().cy(), style.get()); Oops. > LayoutTests/ChangeLog:22 > +2014-08-15 Dirk Schulze <krit@webkit.org> > + > + Turn cx/cy to presentation attributes > + https://bugs.webkit.org/show_bug.cgi?id=135975 > + > + Reviewed by NOBODY (OOPS!). More Oops. Created attachment 236669 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Committed r172642: <http://trac.webkit.org/changeset/172642> Committed r172647: <http://trac.webkit.org/changeset/172647> |