Bug 135974

Summary: master.cfg should handle special return codes of run-perf-tests
Product: WebKit Reporter: Nagy Renátó <rnagy>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ossy, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
rniwa: review+
Proposed patch
none
Proposed patch none

Nagy Renátó
Reported 2014-08-15 05:23:05 PDT
The buildbot shows incorrect results on the performance bots if the run-perf-tests script returns with these special exit codes: 255, 254, 253, 252, 251 For example: http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2%20%28Perf%29/builds/2887 The stdio says clearly what was the problem: Failed to upload JSON file to https://perf.webkit.org/api/report in 120s: program finished with exit code 252 But the buildbot handled this return code improperly: Failed 252 perf tests failed
Attachments
Proposed patch (4.30 KB, patch)
2014-08-15 05:29 PDT, Nagy Renátó 		rniwa: review+
DetailsFormatted DiffDiff
Proposed patch (4.30 KB, patch)
2014-08-18 01:04 PDT, Nagy Renátó 		no flags
DetailsFormatted DiffDiff
Proposed patch (4.29 KB, patch)
2014-08-18 01:16 PDT, Nagy Renátó 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nagy Renátó
Comment 1 2014-08-15 05:29:08 PDT
Created attachment 236647 [details] Proposed patch
WebKit Commit Bot
Comment 2 2014-08-15 05:31:57 PDT
Attachment 236647 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:432: [RunAndUploadPerfTestsTest.assertResults] Undefined variable 'RunAndUploadPerfTests' [pylint/E0602] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryosuke Niwa
Comment 3 2014-08-15 11:23:54 PDT
Comment on attachment 236647 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=236647&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:729 > + if cmd.rc == 255: Can we use -1 & 0xff instead to match the code in perftestrunner.py?
Nagy Renátó
Comment 4 2014-08-18 01:04:32 PDT
Created attachment 236747 [details] Proposed patch
Nagy Renátó
Comment 5 2014-08-18 01:16:44 PDT
Created attachment 236748 [details] Proposed patch
WebKit Commit Bot
Comment 6 2014-08-18 02:52:52 PDT
Comment on attachment 236748 [details] Proposed patch Clearing flags on attachment: 236748 Committed r172701: <http://trac.webkit.org/changeset/172701>
WebKit Commit Bot
Comment 7 2014-08-18 02:52:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.