Summary: | master.cfg should handle special return codes of run-perf-tests | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nagy Renátó <rnagy> | ||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, ossy, rniwa | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Nagy Renátó
2014-08-15 05:23:05 PDT
Created attachment 236647 [details]
Proposed patch
Attachment 236647 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:432: [RunAndUploadPerfTestsTest.assertResults] Undefined variable 'RunAndUploadPerfTests' [pylint/E0602] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 236647 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=236647&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:729 > + if cmd.rc == 255: Can we use -1 & 0xff instead to match the code in perftestrunner.py? Created attachment 236747 [details]
Proposed patch
Created attachment 236748 [details]
Proposed patch
Comment on attachment 236748 [details] Proposed patch Clearing flags on attachment: 236748 Committed r172701: <http://trac.webkit.org/changeset/172701> All reviewed patches have been landed. Closing bug. |