Summary: | CSS JIT: compile :-webkit-full-page-media | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Benjamin Poulain
2014-08-15 00:12:05 PDT
Created attachment 236644 [details]
Patch
Comment on attachment 236644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236644&action=review > Source/WebCore/ChangeLog:10 > + It would be possible to inline it, but this selector is so unommon I don't think Typo: should be "uncommon". > Source/WebCore/css/SelectorCheckerTestFunctions.h:76 > +ALWAYS_INLINE bool isMediaDocument(const Element* element) Does this have to take a const? Node/Element constness is a highly questionable concept, which I thought we agreed to not use, see <https://lists.webkit.org/pipermail/webkit-dev/2011-May/016875.html>. Thanks for the review!
> > Source/WebCore/css/SelectorCheckerTestFunctions.h:76
> > +ALWAYS_INLINE bool isMediaDocument(const Element* element)
>
> Does this have to take a const? Node/Element constness is a highly questionable concept, which I thought we agreed to not use, see <https://lists.webkit.org/pipermail/webkit-dev/2011-May/016875.html>.
The const has no value here, I'll remove it.
Committed r172663: <http://trac.webkit.org/changeset/172663> |