Bug 135968

Summary:

CSS JIT: compile :-webkit-full-page-media

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ap: review+

Benjamin Poulain

Reported 2014-08-15 00:12:05 PDT

CSS JIT: compile :-webkit-full-page-media

Attachments
Patch (3.78 KB, patch) 2014-08-15 00:14 PDT, Benjamin Poulain	ap: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Benjamin Poulain

Comment 1 2014-08-15 00:14:34 PDT

Created attachment 236644 [details] Patch

Alexey Proskuryakov

Comment 2 2014-08-15 10:07:55 PDT

Comment on attachment 236644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236644&action=review > Source/WebCore/ChangeLog:10 > + It would be possible to inline it, but this selector is so unommon I don't think Typo: should be "uncommon". > Source/WebCore/css/SelectorCheckerTestFunctions.h:76 > +ALWAYS_INLINE bool isMediaDocument(const Element* element) Does this have to take a const? Node/Element constness is a highly questionable concept, which I thought we agreed to not use, see <https://lists.webkit.org/pipermail/webkit-dev/2011-May/016875.html>.

Benjamin Poulain

Comment 3 2014-08-15 18:19:17 PDT

Thanks for the review! > > Source/WebCore/css/SelectorCheckerTestFunctions.h:76 > > +ALWAYS_INLINE bool isMediaDocument(const Element* element) > > Does this have to take a const? Node/Element constness is a highly questionable concept, which I thought we agreed to not use, see <https://lists.webkit.org/pipermail/webkit-dev/2011-May/016875.html>. The const has no value here, I'll remove it.

Benjamin Poulain

Comment 4 2014-08-15 18:37:51 PDT

Committed r172663: <http://trac.webkit.org/changeset/172663>

Note You need to log in before you can comment on or make changes to this bug.