| Summary: | Web Inspector: Add layout test for lowercase CSSProperty names | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Baker <mattbaker> | ||||||
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Matt Baker
2014-08-14 15:56:29 PDT
Created attachment 236638 [details]
Patch
Comment on attachment 236638 [details]
Patch
Nice!
Comment on attachment 236638 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236638&action=review > Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js:86 > + // CodeMirror is not included by Test.html, so skip MIME type associations. This should be a generic comment. "CodeMirror is not included in tests, so skip MIME type associations.". The mention of Test.html is too specific and could go stale. > LayoutTests/inspector/css/matched-style-properties.html:8 > + BACKGROUND-COLOR:blue; > + COLOR:white; > + border-STYLE:solid; Might as well test an all lower case, and wild camel case. position: absolute; ToP: 0; lEfT: 0; Created attachment 236694 [details]
Patch
Comment on attachment 236694 [details]
Patch
Patch looks great. However tests are not being run at all?! We should really first unskip all inspector tests before landing this. Could you look into that?
Comment on attachment 236694 [details] Patch Clearing flags on attachment: 236694 Committed r173406: <http://trac.webkit.org/changeset/173406> All reviewed patches have been landed. Closing bug. |