Bug 135955

Summary:

Fixed a bmalloc crash seen on the EWS bot

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

New Bugs

Assignee:

Geoffrey Garen <ggaren>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kling, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+

Description Geoffrey Garen 2014-08-14 14:34:56 PDT

Fixed a bmalloc crash seen on the EWS bot

Comment 1 Geoffrey Garen 2014-08-14 14:37:13 PDT

Created attachment 236621 [details]
Patch

Comment 2 Geoffrey Garen 2014-08-14 14:40:03 PDT

Committed r172608: <http://trac.webkit.org/changeset/172608>

Comment 3 Csaba Osztrogonác 2014-08-15 02:11:29 PDT

(In reply to comment #2)
> Committed r172608: <http://trac.webkit.org/changeset/172608>

Maybe this change caused the issue on Apple Mac WK1 EWS bots:
https://lists.webkit.org/pipermail/webkit-dev/2014-August/026797.html

Could you check it?

Comment 4 Geoffrey Garen 2014-08-15 10:53:50 PDT

> (In reply to comment #2)
> > Committed r172608: <http://trac.webkit.org/changeset/172608>
> 
> Maybe this change caused the issue on Apple Mac WK1 EWS bots:
> https://lists.webkit.org/pipermail/webkit-dev/2014-August/026797.html
> 
> Could you check it?

This patch edited the SYSCALL macro, which is only used by bmalloc, which is disabled. (I just double-checked that there are no other clients of SYSCALL.) So, I think something else must have caused the failure.