| Summary: | Web Inspector: Timelines can get caught in requestAnimationFrame loop when not recording | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | burg, commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 236610 [details]
[PATCH] Proposed Fix
Comment on attachment 236610 [details]
[PATCH] Proposed Fix
Nice!
Comment on attachment 236610 [details] [PATCH] Proposed Fix Clearing flags on attachment: 236610 Committed r172601: <http://trac.webkit.org/changeset/172601> All reviewed patches have been landed. Closing bug. |
* SUMMARY Profiling the inspector the Timelines can get caught in requestAnimationFrame loop when not recording. TimelineContentView.js: _update: function(timestamp) { if (this._waitingToResetCurrentTime) { requestAnimationFrame(this._updateCallback); return; } ... } * STEPS TO REPRODUCE 1. Inspect <http://bogojoker.com/shell/> 2. Reload the page and wait for the Timeline recording to auto stop 3. Reload the page and wait for the Timeline recording to auto stop => looping requestAnimationFrame