Bug 135946

Summary:

Web Inspector: Timelines can get caught in requestAnimationFrame loop when not recording

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

burg, commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2014-08-14 11:37:50 PDT

* SUMMARY Profiling the inspector the Timelines can get caught in requestAnimationFrame loop when not recording. TimelineContentView.js: _update: function(timestamp) { if (this._waitingToResetCurrentTime) { requestAnimationFrame(this._updateCallback); return; } ... } * STEPS TO REPRODUCE 1. Inspect <http://bogojoker.com/shell/> 2. Reload the page and wait for the Timeline recording to auto stop 3. Reload the page and wait for the Timeline recording to auto stop => looping requestAnimationFrame

Attachments
[PATCH] Proposed Fix (6.32 KB, patch) 2014-08-14 12:49 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2014-08-14 11:37:58 PDT

<rdar://problem/18021462>

Joseph Pecoraro

Comment 2 2014-08-14 12:49:32 PDT

Created attachment 236610 [details] [PATCH] Proposed Fix

Timothy Hatcher

Comment 3 2014-08-14 13:07:36 PDT

Comment on attachment 236610 [details] [PATCH] Proposed Fix Nice!

WebKit Commit Bot

Comment 4 2014-08-14 13:40:34 PDT

Comment on attachment 236610 [details] [PATCH] Proposed Fix Clearing flags on attachment: 236610 Committed r172601: <http://trac.webkit.org/changeset/172601>

WebKit Commit Bot

Comment 5 2014-08-14 13:40:37 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.