Bug 135946 – Web Inspector: Timelines can get caught in requestAnimationFrame loop when not recording

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Profiling the inspector the Timelines can get caught in requestAnimationFrame loop when not recording.

TimelineContentView.js:

    _update: function(timestamp)
    {
        if (this._waitingToResetCurrentTime) {
            requestAnimationFrame(this._updateCallback);
            return;
        }
        ...
    }

* STEPS TO REPRODUCE
1. Inspect <http://bogojoker.com/shell/>
2. Reload the page and wait for the Timeline recording to auto stop
3. Reload the page and wait for the Timeline recording to auto stop
  => looping requestAnimationFrame

[Radar WebKit Bug Importer]

<rdar://problem/18021462>

[Joseph Pecoraro]

Created attachment 236610 [details]
[PATCH] Proposed Fix

[Timothy Hatcher]

Comment on attachment 236610 [details]
[PATCH] Proposed Fix

Nice!

[WebKit Commit Bot]

Comment on attachment 236610 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 236610

Committed r172601: <http://trac.webkit.org/changeset/172601>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.