Bug 135946 - Web Inspector: Timelines can get caught in requestAnimationFrame loop when not recording
Summary: Web Inspector: Timelines can get caught in requestAnimationFrame loop when no...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-14 11:37 PDT by Joseph Pecoraro
Modified: 2014-08-14 13:40 PDT (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (6.32 KB, patch)
2014-08-14 12:49 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-08-14 11:37:50 PDT 
* SUMMARY
Profiling the inspector the Timelines can get caught in requestAnimationFrame loop when not recording.

TimelineContentView.js:

    _update: function(timestamp)
    {
        if (this._waitingToResetCurrentTime) {
            requestAnimationFrame(this._updateCallback);
            return;
        }
        ...
    }

* STEPS TO REPRODUCE
1. Inspect <http://bogojoker.com/shell/>
2. Reload the page and wait for the Timeline recording to auto stop
3. Reload the page and wait for the Timeline recording to auto stop
  => looping requestAnimationFrame
Comment 1 Radar WebKit Bug Importer 2014-08-14 11:37:58 PDT 
<rdar://problem/18021462>
Comment 2 Joseph Pecoraro 2014-08-14 12:49:32 PDT 
Created attachment 236610 [details]
[PATCH] Proposed Fix
Comment 3 Timothy Hatcher 2014-08-14 13:07:36 PDT 
Comment on attachment 236610 [details]
[PATCH] Proposed Fix

Nice!
Comment 4 WebKit Commit Bot 2014-08-14 13:40:34 PDT 
Comment on attachment 236610 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 236610

Committed r172601: <http://trac.webkit.org/changeset/172601>
Comment 5 WebKit Commit Bot 2014-08-14 13:40:37 PDT 
All reviewed patches have been landed.  Closing bug.