Bug 135941

Summary:

[Services with UI] Selection services don't work inside <iframes>

Product:

WebKit

Reporter:

Enrica Casucci <enrica>

Component:

WebCore Misc.

Assignee:

Enrica Casucci <enrica>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

thorton

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Test	none
Patch	thorton: review+

Description Enrica Casucci 2014-08-14 09:46:35 PDT

Created attachment 236593 [details]
Test

Use the attached test case.
Select something inside the iframe.
Hover to get the service UI.

EXPECTED: The service UI appears and you can click on the arrow.

ACTUAL: Nothing happens.

<rdar://problem/17957690>

Comment 1 Enrica Casucci 2014-08-14 09:52:18 PDT

Created attachment 236595 [details]
Patch

Comment 2 Tim Horton 2014-08-14 10:53:55 PDT

Comment on attachment 236595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236595&action=review

> Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:524
> +    FrameView* viewForRange = selectionRange ? selectionRange->ownerDocument().view() : nullptr;

You dereference this inside the loop; should we just bail if !selectionRange instead?

Comment 3 Enrica Casucci 2014-08-14 11:37:55 PDT

Committed revision 172596.