Bug 135941

Summary: [Services with UI] Selection services don't work inside <iframes>
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: WebCore Misc.Assignee: Enrica Casucci <enrica>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Test
none
Patch thorton: review+

Enrica Casucci
Reported 2014-08-14 09:46:35 PDT
Created attachment 236593 [details] Test Use the attached test case. Select something inside the iframe. Hover to get the service UI. EXPECTED: The service UI appears and you can click on the arrow. ACTUAL: Nothing happens. <rdar://problem/17957690>
Attachments
Test (155 bytes, text/html)
2014-08-14 09:46 PDT, Enrica Casucci 		no flags
Details
Patch (2.75 KB, patch)
2014-08-14 09:52 PDT, Enrica Casucci 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Enrica Casucci
Comment 1 2014-08-14 09:52:18 PDT
Created attachment 236595 [details] Patch
Tim Horton
Comment 2 2014-08-14 10:53:55 PDT
Comment on attachment 236595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236595&action=review > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:524 > + FrameView* viewForRange = selectionRange ? selectionRange->ownerDocument().view() : nullptr; You dereference this inside the loop; should we just bail if !selectionRange instead?
Enrica Casucci
Comment 3 2014-08-14 11:37:55 PDT
Committed revision 172596.
Note You need to log in before you can comment on or make changes to this bug.