Bug 135938

Summary:

Remove nonRendererStyle

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	kling: review+

Description Antti Koivisto 2014-08-14 07:00:22 PDT

We should use computedStyle instead.

Comment 1 Antti Koivisto 2014-08-14 07:13:02 PDT

Created attachment 236588 [details]
patch

Comment 2 WebKit Commit Bot 2014-08-14 07:14:41 PDT

Attachment 236588 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Element.cpp:2865:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Andreas Kling 2014-08-14 10:24:46 PDT

Comment on attachment 236588 [details]
patch

r=me

Would be nice if we could allow style sharing for option and optgroup after this is fixed.

Comment 4 Antti Koivisto 2014-08-14 10:52:10 PDT

https://trac.webkit.org/r172591