Bug 135910

Summary:

run-webkit-tests should skip 'support' directories

Product:

WebKit

Reporter:

Rebecca Hauck <rhauck>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bjonesbe, commit-queue, glenn, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

135921

Attachments:

Description	Flags
Patch for the bug	none

Description Rebecca Hauck 2014-08-13 15:35:21 PDT

We explicitly skip a whole bunch of directories known to not contain any test files (reference, resources, etc.).  The W3C puts all support files in a directory named support, the runner should be updated to skip that, too so imported w3c tests needn't be modified.

Comment 1 Rebecca Hauck 2014-08-13 16:08:22 PDT

Created attachment 236561 [details]
Patch for the bug

Comment 2 Bem Jones-Bey 2014-08-13 16:14:48 PDT

r=me, we already have support directories in the tree, they just are lucky and don't contain anything that looks like a test.

I'd like to double check with Ryosuke before landing, though.

Comment 3 Ryosuke Niwa 2014-08-15 11:30:31 PDT

Comment on attachment 236561 [details]
Patch for the bug

Looks great to me.

Comment 4 WebKit Commit Bot 2014-08-15 12:04:20 PDT

Comment on attachment 236561 [details]
Patch for the bug

Clearing flags on attachment: 236561

Committed r172638: <http://trac.webkit.org/changeset/172638>

Comment 5 WebKit Commit Bot 2014-08-15 12:04:24 PDT

All reviewed patches have been landed.  Closing bug.