Bug 135908 – Opening Web Inspector causes a large amount of sandbox violations

• Component: WebKit2
• Status: RESOLVED FIXED

[Joseph Pecoraro]

* SUMMARY
Opening Web Inspector causes a large amount of "deny file-issue-extension" sandbox violations:

>    com.apple.WebKit(93849) deny file-issue-extension /System/Library/PrivateFrameworks/WebInspectorUI.framework/Versions/A/Resources/Main.html
>    com.apple.WebKit(93849) deny file-issue-extension /System/Library/PrivateFrameworks/WebInspectorUI.framework/Versions/A/Resources/CodeMirror.css
>    com.apple.WebKit(93849) deny file-issue-extension /System/Library/PrivateFrameworks/WebInspectorUI.framework/Versions/A/Resources/Main.css
>    ...

* NOTES
This doesn't happen with local builds which does not use /S/L/PF/WebInspectorUI.framework but instead your own built WebInspectorUI.framework.

<rdar://problem/17998706>

[Joseph Pecoraro]

Created attachment 236555 [details]
[PATCH] Proposed Fix

[Timothy Hatcher]

Comment on attachment 236555 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=236555&action=review

> Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in:97
> +(allow-read-directory-and-issue-read-extensions "/System/Library/PrivateFrameworks/WebInspectorUI.framework")

Do we also need to add /System/Library/StagedFrameworks/Safari/WebInspectorUI.framework?

[Alexey Proskuryakov]

r=me as well.

We shouldn't need StagedFrameworks, because WebInspectorUI.framework ends up being in the same directory as WebKit.framework, and thus the existing rule does the trick:

(allow-read-directory-and-issue-read-extensions (param "WEBKIT2_FRAMEWORK_DIR"))

[WebKit Commit Bot]

Comment on attachment 236555 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 236555

Committed r172539: <http://trac.webkit.org/changeset/172539>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.