Bug 135900 – Do not use FloatRect::infiniteRect() to flag full repaints.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

Converting FloatRect::infiniteRect() to IntRect produces value overflow an we end up with invalid repaint coordinates.

[zalan]

Created attachment 236546 [details]
Patch

[WebKit Commit Bot]

Attachment 236546 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:485:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 236546 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236546&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:716
> +    m_needsFullRepaint = true;
> +    m_dirtyRects.clear();
> +    noteLayerPropertyChanged(DirtyRectsChanged);
> +    addRepaintRect(FloatRect(FloatPoint(), m_size));

This is missing the if (!drawsContent()) that setNeedsDisplayInRect() does.

[zalan]

Created attachment 236549 [details]
Patch

[WebKit Commit Bot]

Attachment 236549 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:485:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[zalan]

Created attachment 236556 [details]
Patch

[WebKit Commit Bot]

Attachment 236556 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:485:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[zalan]

Created attachment 236681 [details]
Patch

[WebKit Commit Bot]

Attachment 236681 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:485:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 236681 [details]
Patch

Clearing flags on attachment: 236681

Committed r172681: <http://trac.webkit.org/changeset/172681>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.