Bug 135900 - Do not use FloatRect::infiniteRect() to flag full repaints.
Summary: Do not use FloatRect::infiniteRect() to flag full repaints.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-13 13:38 PDT by zalan
Modified: 2014-08-15 21:04 PDT (History)
4 users (show)

See Also:


Attachments
Patch (16.79 KB, patch)
2014-08-13 13:49 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (16.84 KB, patch)
2014-08-13 14:01 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (21.46 KB, patch)
2014-08-13 15:25 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (21.69 KB, patch)
2014-08-15 15:35 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-08-13 13:38:04 PDT
Converting FloatRect::infiniteRect() to IntRect produces value overflow an we end up with invalid repaint coordinates.
Comment 1 zalan 2014-08-13 13:49:48 PDT
Created attachment 236546 [details]
Patch
Comment 2 WebKit Commit Bot 2014-08-13 13:50:45 PDT
Attachment 236546 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:485:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2014-08-13 13:51:04 PDT
Comment on attachment 236546 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236546&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:716
> +    m_needsFullRepaint = true;
> +    m_dirtyRects.clear();
> +    noteLayerPropertyChanged(DirtyRectsChanged);
> +    addRepaintRect(FloatRect(FloatPoint(), m_size));

This is missing the if (!drawsContent()) that setNeedsDisplayInRect() does.
Comment 4 zalan 2014-08-13 14:01:41 PDT
Created attachment 236549 [details]
Patch
Comment 5 WebKit Commit Bot 2014-08-13 14:04:35 PDT
Attachment 236549 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:485:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 zalan 2014-08-13 15:25:05 PDT
Created attachment 236556 [details]
Patch
Comment 7 WebKit Commit Bot 2014-08-13 15:27:25 PDT
Attachment 236556 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:485:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 zalan 2014-08-15 15:35:51 PDT
Created attachment 236681 [details]
Patch
Comment 9 WebKit Commit Bot 2014-08-15 15:37:13 PDT
Attachment 236681 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:485:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 WebKit Commit Bot 2014-08-15 21:03:58 PDT
Comment on attachment 236681 [details]
Patch

Clearing flags on attachment: 236681

Committed r172681: <http://trac.webkit.org/changeset/172681>
Comment 11 WebKit Commit Bot 2014-08-15 21:04:02 PDT
All reviewed patches have been landed.  Closing bug.