RESOLVED FIXED 135900
Do not use FloatRect::infiniteRect() to flag full repaints. 
https://bugs.webkit.org/show_bug.cgi?id=135900
Summary Do not use FloatRect::infiniteRect() to flag full repaints.
zalan
Reported 2014-08-13 13:38:04 PDT
Converting FloatRect::infiniteRect() to IntRect produces value overflow an we end up with invalid repaint coordinates.
Attachments
Patch (16.79 KB, patch)
2014-08-13 13:49 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (16.84 KB, patch)
2014-08-13 14:01 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (21.46 KB, patch)
2014-08-13 15:25 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (21.69 KB, patch)
2014-08-15 15:35 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2014-08-13 13:49:48 PDT
Created attachment 236546 [details] Patch
WebKit Commit Bot
Comment 2 2014-08-13 13:50:45 PDT
Attachment 236546 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:485: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 3 2014-08-13 13:51:04 PDT
Comment on attachment 236546 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236546&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:716 > + m_needsFullRepaint = true; > + m_dirtyRects.clear(); > + noteLayerPropertyChanged(DirtyRectsChanged); > + addRepaintRect(FloatRect(FloatPoint(), m_size)); This is missing the if (!drawsContent()) that setNeedsDisplayInRect() does.
zalan
Comment 4 2014-08-13 14:01:41 PDT
Created attachment 236549 [details] Patch
WebKit Commit Bot
Comment 5 2014-08-13 14:04:35 PDT
Attachment 236549 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:485: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
zalan
Comment 6 2014-08-13 15:25:05 PDT
Created attachment 236556 [details] Patch
WebKit Commit Bot
Comment 7 2014-08-13 15:27:25 PDT
Attachment 236556 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:485: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
zalan
Comment 8 2014-08-15 15:35:51 PDT
Created attachment 236681 [details] Patch
WebKit Commit Bot
Comment 9 2014-08-15 15:37:13 PDT
Attachment 236681 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:485: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 10 2014-08-15 21:03:58 PDT
Comment on attachment 236681 [details] Patch Clearing flags on attachment: 236681 Committed r172681: <http://trac.webkit.org/changeset/172681>
WebKit Commit Bot
Comment 11 2014-08-15 21:04:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.