Bug 135888

Summary: enable llint on Windows CMake build
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebKit Misc.Assignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, bunhere, commit-queue, gyuyoung.kim, laszlo.gombos, mrobinson, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alex Christensen
Reported 2014-08-13 10:41:42 PDT
Windows puts assembly in a separate file instead of LLIntAssembly.h because of string length limits (2^16-1) in Visual Studio. The CMake build needs to be tweaked to do this, too.
Attachments
Patch (4.71 KB, patch)
2014-08-13 10:47 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2014-08-13 10:47:11 PDT
Created attachment 236534 [details] Patch
Brent Fulgham
Comment 2 2014-08-18 14:45:40 PDT
Comment on attachment 236534 [details] Patch Looks good to me, too.
WebKit Commit Bot
Comment 3 2014-08-19 10:37:13 PDT
Comment on attachment 236534 [details] Patch Clearing flags on attachment: 236534 Committed r172754: <http://trac.webkit.org/changeset/172754>
WebKit Commit Bot
Comment 4 2014-08-19 10:37:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.