Bug 135888

Summary:

enable llint on Windows CMake build

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

WebKit Misc.

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, bunhere, commit-queue, gyuyoung.kim, laszlo.gombos, mrobinson, rakuco, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Alex Christensen 2014-08-13 10:41:42 PDT

Windows puts assembly in a separate file instead of LLIntAssembly.h because of string length limits (2^16-1) in Visual Studio.  The CMake build needs to be tweaked to do this, too.

Comment 1 Alex Christensen 2014-08-13 10:47:11 PDT

Created attachment 236534 [details]
Patch

Comment 2 Brent Fulgham 2014-08-18 14:45:40 PDT

Comment on attachment 236534 [details]
Patch

Looks good to me, too.

Comment 3 WebKit Commit Bot 2014-08-19 10:37:13 PDT

Comment on attachment 236534 [details]
Patch

Clearing flags on attachment: 236534

Committed r172754: <http://trac.webkit.org/changeset/172754>

Comment 4 WebKit Commit Bot 2014-08-19 10:37:17 PDT

All reviewed patches have been landed.  Closing bug.