Summary: | [EFL] Introduce DEVELOPER_MODE | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryuan Choi <ryuan.choi> | ||||||
Component: | WebKit EFL | Assignee: | Ryuan Choi <ryuan.choi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bunhere, commit-queue, dbates, gyuyoung.kim, lucas.de.marchi, ossy, rakuco, sergio | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 80683 | ||||||||
Attachments: |
|
Description
Ryuan Choi
2014-08-13 09:28:16 PDT
Created attachment 236530 [details]
Patch
Comment on attachment 236530 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236530&action=review > Source/cmake/OptionsEfl.cmake:301 > + if (CMAKE_COMPILER_IS_GNUCXX OR "${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang") Is this compiler check necessary here ? Which other compilers are supported ? Created attachment 236570 [details]
Patch
(In reply to comment #2) > (From update of attachment 236530 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=236530&action=review > > > Source/cmake/OptionsEfl.cmake:301 > > + if (CMAKE_COMPILER_IS_GNUCXX OR "${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang") > > Is this compiler check necessary here ? Which other compilers are supported ? No, at least now. I removed it. Comment on attachment 236570 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236570&action=review > Tools/Scripts/webkitdirs.pm:1944 > # GTK+ has a production mode, but build-webkit should always use developer mode. According to this comment, gtk port looks have a production mode. So, they set developer mode as default. However, do we have production mode as gtk port ? Comment on attachment 236570 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236570&action=review > Source/cmake/OptionsEfl.cmake:50 > set(VERSION_SCRIPT "-Wl,--version-script,${CMAKE_MODULE_PATH}/eflsymbols.filter") I think we need to move this line into 60 line, because this is no meaning when DEVELOPER_MODE is ON. Comment on attachment 236570 [details]
Patch
Please land this patch after fixing my comment. r=me.
(In reply to comment #7) > (From update of attachment 236570 [details]) > Please land this patch after fixing my comment. r=me. Ryuan, I want to land this patch in order not to use SHARED_CORE anymore. Please land this patch after fixing my comment !!!! Committed r172894: <http://trac.webkit.org/changeset/172894> Comment on attachment 236570 [details]
Patch
landed manually after followed gyuyoung's comment
|