Bug 135884

Summary: [EFL] Introduce DEVELOPER_MODE
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, commit-queue, dbates, gyuyoung.kim, lucas.de.marchi, ossy, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 80683    
Attachments:
Description Flags
Patch
none
Patch none

Ryuan Choi
Reported 2014-08-13 09:28:16 PDT
Like GTK port, DEVELOPER_MODE can be good solution for developing, debugging and testing instead of SHARED_CORE. SHARED_CORE can reduce link time and memory consumption but it is slightly different from release binary.
Attachments
Patch (4.78 KB, patch)
2014-08-13 09:31 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (4.68 KB, patch)
2014-08-13 17:33 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2014-08-13 09:31:52 PDT
Created attachment 236530 [details] Patch
Laszlo Gombos
Comment 2 2014-08-13 11:19:04 PDT
Comment on attachment 236530 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236530&action=review > Source/cmake/OptionsEfl.cmake:301 > + if (CMAKE_COMPILER_IS_GNUCXX OR "${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang") Is this compiler check necessary here ? Which other compilers are supported ?
Ryuan Choi
Comment 3 2014-08-13 17:33:51 PDT
Created attachment 236570 [details] Patch
Ryuan Choi
Comment 4 2014-08-13 17:34:14 PDT
(In reply to comment #2) > (From update of attachment 236530 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=236530&action=review > > > Source/cmake/OptionsEfl.cmake:301 > > + if (CMAKE_COMPILER_IS_GNUCXX OR "${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang") > > Is this compiler check necessary here ? Which other compilers are supported ? No, at least now. I removed it.
Gyuyoung Kim
Comment 5 2014-08-13 18:51:00 PDT
Comment on attachment 236570 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236570&action=review > Tools/Scripts/webkitdirs.pm:1944 > # GTK+ has a production mode, but build-webkit should always use developer mode. According to this comment, gtk port looks have a production mode. So, they set developer mode as default. However, do we have production mode as gtk port ?
Gyuyoung Kim
Comment 6 2014-08-21 23:04:17 PDT
Comment on attachment 236570 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236570&action=review > Source/cmake/OptionsEfl.cmake:50 > set(VERSION_SCRIPT "-Wl,--version-script,${CMAKE_MODULE_PATH}/eflsymbols.filter") I think we need to move this line into 60 line, because this is no meaning when DEVELOPER_MODE is ON.
Gyuyoung Kim
Comment 7 2014-08-22 02:56:52 PDT
Comment on attachment 236570 [details] Patch Please land this patch after fixing my comment. r=me.
Gyuyoung Kim
Comment 8 2014-08-22 23:08:46 PDT
(In reply to comment #7) > (From update of attachment 236570 [details]) > Please land this patch after fixing my comment. r=me. Ryuan, I want to land this patch in order not to use SHARED_CORE anymore. Please land this patch after fixing my comment !!!!
Ryuan Choi
Comment 9 2014-08-24 02:13:32 PDT
Committed r172894: <http://trac.webkit.org/changeset/172894>
Ryuan Choi
Comment 10 2014-08-24 04:26:20 PDT
Comment on attachment 236570 [details] Patch landed manually after followed gyuyoung's comment
Note You need to log in before you can comment on or make changes to this bug.