Bug 135843

Summary:

BPLATFORM(IOS) always evaluates to false

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

New Bugs

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, ggaren, kling, rniwa, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

135848

Attachments:

Description	Flags
Patch	ggaren: review+

Description Daniel Bates 2014-08-12 10:10:16 PDT

BPLATFORM(IOS) always evaluates to false regardless of whether we are building bmalloc for iOS. Moreover, BPLATFORM(X) always evaluates to false for any X.

Comment 1 Daniel Bates 2014-08-12 10:11:44 PDT

Created attachment 236452 [details]
Patch

Comment 2 Daniel Bates 2014-08-12 10:20:33 PDT

The patch for bug #131658 defined BPLATFORM(X) as (defined BPLATFORM_##PLATFORM && PLATFORM_##PLATFORM).

Notice that the second conjunct is PLATFORM_##PLATFORM. But it should be BPLATFORM_##PLATFORM. Otherwise BPLATFORM(X) will always evaluate to false for any X since PLATFORM_X is undefined for any X and an undefined macro value evaluates to false in a boolean context.

Comment 3 Geoffrey Garen 2014-08-12 12:45:37 PDT

Comment on attachment 236452 [details]
Patch

r=me

Comment 4 Daniel Bates 2014-08-12 19:27:48 PDT

For completeness, with the proposed change iOS will use 16kB pages instead of 4kb pages.

Comment 5 Daniel Bates 2014-08-12 19:33:25 PDT

Committed r172510: <http://trac.webkit.org/changeset/172510>