Bug 135843

Summary: BPLATFORM(IOS) always evaluates to false
Product: WebKit Reporter: Daniel Bates <dbates>
Component: New BugsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, kling, rniwa, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 135848    
Attachments:
Description Flags
Patch ggaren: review+

Daniel Bates
Reported 2014-08-12 10:10:16 PDT
BPLATFORM(IOS) always evaluates to false regardless of whether we are building bmalloc for iOS. Moreover, BPLATFORM(X) always evaluates to false for any X.
Attachments
Patch (1.55 KB, patch)
2014-08-12 10:11 PDT, Daniel Bates 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2014-08-12 10:11:44 PDT
Created attachment 236452 [details] Patch
Daniel Bates
Comment 2 2014-08-12 10:20:33 PDT
The patch for bug #131658 defined BPLATFORM(X) as (defined BPLATFORM_##PLATFORM && PLATFORM_##PLATFORM). Notice that the second conjunct is PLATFORM_##PLATFORM. But it should be BPLATFORM_##PLATFORM. Otherwise BPLATFORM(X) will always evaluate to false for any X since PLATFORM_X is undefined for any X and an undefined macro value evaluates to false in a boolean context.
Geoffrey Garen
Comment 3 2014-08-12 12:45:37 PDT
Comment on attachment 236452 [details] Patch r=me
Daniel Bates
Comment 4 2014-08-12 19:27:48 PDT
For completeness, with the proposed change iOS will use 16kB pages instead of 4kb pages.
Daniel Bates
Comment 5 2014-08-12 19:33:25 PDT
Committed r172510: <http://trac.webkit.org/changeset/172510>
Note You need to log in before you can comment on or make changes to this bug.