| Summary: | [CMAKE] WebProcess shouldn't need to explicitly link to JavaScriptCore and WebCore | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bunhere, cdumez, commit-queue, gyuyoung.kim, pnormand, rakuco, ryuan.choi, sergio | ||||
| Priority: | P2 | Keywords: | Gtk | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Carlos Garcia Campos
2014-08-12 00:43:19 PDT
Created attachment 236430 [details]
Patch
Gyuyoung, could you please confirm this patch doesn't break the EFL build with shared WebCore?
I don't remember why it was required long time ago. But I can confirm that EFL port looks fine now with this patch whatever SHARED_CORE is ON/OFF. (In reply to comment #1) > Created an attachment (id=236430) [details] > Patch > > Gyuyoung, could you please confirm this patch doesn't break the EFL build with shared WebCore? When I test this patch locally, there is no build break. Besides I let efl-ews to build with SHARED_CORE=ON yesterday. Additionally I'm taking a look how to run layout test on EFL port regardless of SHARED_CORE. (In reply to comment #2) > I don't remember why it was required long time ago. IIRC, initial EFL WK1 DumpRenderTree was implemented only with SHARED_CORE=ON because SAHRED_CORE reduces linking time on debug build. It looks nobody checked EFL layout test failed on release build at that time. IMO, that's why EFL port should enable SHARED_CORE to run layout test. However, it looks EFL WK2 doesn't need to enable it if we set something environment variables. Let me post when I solve this issue. Committed r172516: <http://trac.webkit.org/changeset/172516> |