Bug 135832

Summary: [CMAKE] WebProcess shouldn't need to explicitly link to JavaScriptCore and WebCore
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, pnormand, rakuco, ryuan.choi, sergio
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch gyuyoung.kim: review+

Carlos Garcia Campos
Reported 2014-08-12 00:43:19 PDT
Linking to WebKit2 should be enough, like Network and Plugin processes.
Attachments
Patch (950 bytes, patch)
2014-08-12 00:45 PDT, Carlos Garcia Campos 		gyuyoung.kim: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2014-08-12 00:45:49 PDT
Created attachment 236430 [details] Patch Gyuyoung, could you please confirm this patch doesn't break the EFL build with shared WebCore?
Ryuan Choi
Comment 2 2014-08-12 16:50:45 PDT
I don't remember why it was required long time ago. But I can confirm that EFL port looks fine now with this patch whatever SHARED_CORE is ON/OFF.
Gyuyoung Kim
Comment 3 2014-08-12 22:38:11 PDT
(In reply to comment #1) > Created an attachment (id=236430) [details] > Patch > > Gyuyoung, could you please confirm this patch doesn't break the EFL build with shared WebCore? When I test this patch locally, there is no build break. Besides I let efl-ews to build with SHARED_CORE=ON yesterday. Additionally I'm taking a look how to run layout test on EFL port regardless of SHARED_CORE.
Gyuyoung Kim
Comment 4 2014-08-12 22:42:44 PDT
(In reply to comment #2) > I don't remember why it was required long time ago. IIRC, initial EFL WK1 DumpRenderTree was implemented only with SHARED_CORE=ON because SAHRED_CORE reduces linking time on debug build. It looks nobody checked EFL layout test failed on release build at that time. IMO, that's why EFL port should enable SHARED_CORE to run layout test. However, it looks EFL WK2 doesn't need to enable it if we set something environment variables. Let me post when I solve this issue.
Carlos Garcia Campos
Comment 5 2014-08-12 23:44:59 PDT
Committed r172516: <http://trac.webkit.org/changeset/172516>
Note You need to log in before you can comment on or make changes to this bug.