Summary: | generate header detection files on Windows CMake | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
Component: | WebCore Misc. | Assignee: | Alex Christensen <achristensen> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, bfulgham, bunhere, cmarcelo, commit-queue, gyuyoung.kim, laszlo.gombos, rakuco, sergio | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Alex Christensen
2014-08-11 10:59:42 PDT
Created attachment 236383 [details]
Patch
Comment on attachment 236383 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236383&action=review r=me. Please change those bugs to be "FIXME(Bug ###)" format, with bugs filed to extend the CMake stuff to do what we need for internal use. > Source/WTF/wtf/PlatformWin.cmake:22 > +#FIXME: This should run testOSXLevel.cmd if it is available. Please file a bug and make this a #FIXME(Bug##) bug. > Source/WebCore/PlatformWin.cmake:93 > +#FIXME: This should test if AVF headers are available. Ditto above comment. Added comments and committed to http://trac.webkit.org/changeset/172499 |