Bug 135807

Summary:

generate header detection files on Windows CMake

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

WebCore Misc.

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, bfulgham, bunhere, cmarcelo, commit-queue, gyuyoung.kim, laszlo.gombos, rakuco, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	bfulgham: review+, bfulgham: commit-queue-

Alex Christensen

Reported 2014-08-11 10:59:42 PDT

The Windows build requires WTF/WTFHeaderDetection.h and WebCore/WebCoreHeaderDetection.h, which are generated by testing for the existence of Apple internal stuff. I've implemented the stubs of these headers to get them to compile without detecting the internal stuff, which will need to be done later.

Attachments
Patch (4.74 KB, patch) 2014-08-11 11:03 PDT, Alex Christensen	bfulgham: review+ bfulgham: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2014-08-11 11:03:08 PDT

Created attachment 236383 [details] Patch

Brent Fulgham

Comment 2 2014-08-12 14:32:37 PDT

Comment on attachment 236383 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236383&action=review r=me. Please change those bugs to be "FIXME(Bug ###)" format, with bugs filed to extend the CMake stuff to do what we need for internal use. > Source/WTF/wtf/PlatformWin.cmake:22 > +#FIXME: This should run testOSXLevel.cmd if it is available. Please file a bug and make this a #FIXME(Bug##) bug. > Source/WebCore/PlatformWin.cmake:93 > +#FIXME: This should test if AVF headers are available. Ditto above comment.

Alex Christensen

Comment 3 2014-08-12 15:44:00 PDT

Added comments and committed to http://trac.webkit.org/changeset/172499

Note You need to log in before you can comment on or make changes to this bug.