Bug 135803

Summary:

Web Inspector: use type builders to construct high fidelity type information payloads

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Brian Burg <burg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, saam, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Brian Burg 2014-08-11 09:40:34 PDT

Due to a typo in Runtime.json, it seems that all of the payload construction code works with raw unchecked objects. We should use type builders.

Comment 1 Radar WebKit Bug Importer 2014-08-11 09:40:46 PDT

<rdar://problem/17977654>

Comment 2 Brian Burg 2014-08-11 10:41:08 PDT

Created attachment 236379 [details]
Patch

Comment 3 WebKit Commit Bot 2014-08-11 10:43:01 PDT

Attachment 236379 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/HighFidelityTypeProfiler.h:99:  The parameter name "descriptor" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 WebKit Commit Bot 2014-08-11 12:20:05 PDT

Comment on attachment 236379 [details]
Patch

Clearing flags on attachment: 236379

Committed r172402: <http://trac.webkit.org/changeset/172402>

Comment 5 WebKit Commit Bot 2014-08-11 12:20:08 PDT

All reviewed patches have been landed.  Closing bug.