Bug 135803 - Web Inspector: use type builders to construct high fidelity type information payloads
Summary: Web Inspector: use type builders to construct high fidelity type information ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-11 09:40 PDT by Brian Burg
Modified: 2014-08-11 12:20 PDT (History)
6 users (show)

See Also:

Attachments
Patch (18.56 KB, patch)
2014-08-11 10:41 PDT, Brian Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2014-08-11 09:40:34 PDT 
Due to a typo in Runtime.json, it seems that all of the payload construction code works with raw unchecked objects. We should use type builders.
Comment 1 Radar WebKit Bug Importer 2014-08-11 09:40:46 PDT 
<rdar://problem/17977654>
Comment 2 Brian Burg 2014-08-11 10:41:08 PDT 
Created attachment 236379 [details]
Patch
Comment 3 WebKit Commit Bot 2014-08-11 10:43:01 PDT 
Attachment 236379 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/HighFidelityTypeProfiler.h:99:  The parameter name "descriptor" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Commit Bot 2014-08-11 12:20:05 PDT 
Comment on attachment 236379 [details]
Patch

Clearing flags on attachment: 236379

Committed r172402: <http://trac.webkit.org/changeset/172402>
Comment 5 WebKit Commit Bot 2014-08-11 12:20:08 PDT 
All reviewed patches have been landed.  Closing bug.