Summary: | [EFL][WK2] Minibrowser: Enhance the application to use download directory selector | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shivakumar J M <shiva.jm> | ||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, gyuyoung.kim, lucas.de.marchi, ryuan.choi | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Shivakumar J M
2014-08-10 22:19:03 PDT
Created attachment 236351 [details]
Patch
Currently Minibrowser stores the downloaded files to /tmp directory, add support so that destination folder can be selected by the user.
Comment on attachment 236351 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236351&action=review Looks fine. > Tools/MiniBrowser/efl/main.c:662 > + Eina_Stringshare *save_file_path = show_file_entry_dialog(window, "DOWNLOAD", home_path ? home_path : "/home"); Isn't it better to use /tmp when *home_path* isn't set ? > Tools/MiniBrowser/efl/main.c:674 > + eina_strbuf_append(destination_path, "/downloaded-file.XXXXXX"); Can't we change download file name as well ? Created attachment 236428 [details]
Patch for landing
Comment on attachment 236428 [details] Patch for landing Clearing flags on attachment: 236428 Committed r172437: <http://trac.webkit.org/changeset/172437> All reviewed patches have been landed. Closing bug. |