Bug 135791 – [EFL][WK2] Minibrowser: Enhance the application to use download directory selector

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Shivakumar J M]

Currently Minibrowser stores the downloaded files to /tmp directory, so add support so that destination folder can be selected by the user.

[Shivakumar J M]

Created attachment 236351 [details]
Patch

Currently Minibrowser stores the downloaded files to /tmp directory, add support so that destination folder can be selected by the user.

[Gyuyoung Kim]

Comment on attachment 236351 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236351&action=review

Looks fine.

> Tools/MiniBrowser/efl/main.c:662
> +    Eina_Stringshare *save_file_path = show_file_entry_dialog(window, "DOWNLOAD", home_path ? home_path : "/home");

Isn't it better to use /tmp when *home_path* isn't set ?

> Tools/MiniBrowser/efl/main.c:674
> +        eina_strbuf_append(destination_path, "/downloaded-file.XXXXXX");

Can't we change download file name as well ?

[Shivakumar J M]

Created attachment 236428 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 236428 [details]
Patch for landing

Clearing flags on attachment: 236428

Committed r172437: <http://trac.webkit.org/changeset/172437>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.