RESOLVED FIXED135791
[EFL][WK2] Minibrowser: Enhance the application to use download directory selector 
https://bugs.webkit.org/show_bug.cgi?id=135791
Summary [EFL][WK2] Minibrowser: Enhance the application to use download directory sel...
Shivakumar J M
Reported 2014-08-10 22:19:03 PDT
Currently Minibrowser stores the downloaded files to /tmp directory, so add support so that destination folder can be selected by the user.
Attachments
Patch (2.92 KB, patch)
2014-08-10 22:36 PDT, Shivakumar J M 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.89 KB, patch)
2014-08-11 21:46 PDT, Shivakumar J M 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shivakumar J M
Comment 1 2014-08-10 22:36:09 PDT
Created attachment 236351 [details] Patch Currently Minibrowser stores the downloaded files to /tmp directory, add support so that destination folder can be selected by the user.
Gyuyoung Kim
Comment 2 2014-08-11 21:07:41 PDT
Comment on attachment 236351 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236351&action=review Looks fine. > Tools/MiniBrowser/efl/main.c:662 > + Eina_Stringshare *save_file_path = show_file_entry_dialog(window, "DOWNLOAD", home_path ? home_path : "/home"); Isn't it better to use /tmp when *home_path* isn't set ? > Tools/MiniBrowser/efl/main.c:674 > + eina_strbuf_append(destination_path, "/downloaded-file.XXXXXX"); Can't we change download file name as well ?
Shivakumar J M
Comment 3 2014-08-11 21:46:00 PDT
Created attachment 236428 [details] Patch for landing
WebKit Commit Bot
Comment 4 2014-08-12 01:22:20 PDT
Comment on attachment 236428 [details] Patch for landing Clearing flags on attachment: 236428 Committed r172437: <http://trac.webkit.org/changeset/172437>
WebKit Commit Bot
Comment 5 2014-08-12 01:22:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.