Bug 135791 - [EFL][WK2] Minibrowser: Enhance the application to use download directory selector
Summary: [EFL][WK2] Minibrowser: Enhance the application to use download directory sel...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-10 22:19 PDT by Shivakumar J M
Modified: 2014-08-12 01:22 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.92 KB, patch)
2014-08-10 22:36 PDT, Shivakumar J M 		no flags Details | Formatted Diff | Diff
Patch for landing (2.89 KB, patch)
2014-08-11 21:46 PDT, Shivakumar J M 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shivakumar J M 2014-08-10 22:19:03 PDT 
Currently Minibrowser stores the downloaded files to /tmp directory, so add support so that destination folder can be selected by the user.
Comment 1 Shivakumar J M 2014-08-10 22:36:09 PDT 
Created attachment 236351 [details]
Patch

Currently Minibrowser stores the downloaded files to /tmp directory, add support so that destination folder can be selected by the user.
Comment 2 Gyuyoung Kim 2014-08-11 21:07:41 PDT 
Comment on attachment 236351 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=236351&action=review

Looks fine.

> Tools/MiniBrowser/efl/main.c:662
> +    Eina_Stringshare *save_file_path = show_file_entry_dialog(window, "DOWNLOAD", home_path ? home_path : "/home");

Isn't it better to use /tmp when *home_path* isn't set ?

> Tools/MiniBrowser/efl/main.c:674
> +        eina_strbuf_append(destination_path, "/downloaded-file.XXXXXX");

Can't we change download file name as well ?
Comment 3 Shivakumar J M 2014-08-11 21:46:00 PDT 
Created attachment 236428 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2014-08-12 01:22:20 PDT 
Comment on attachment 236428 [details]
Patch for landing

Clearing flags on attachment: 236428

Committed r172437: <http://trac.webkit.org/changeset/172437>
Comment 5 WebKit Commit Bot 2014-08-12 01:22:25 PDT 
All reviewed patches have been landed.  Closing bug.