Bug 135782

Summary: for-in optimization should also make sure the base matches the object being iterated
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, mark.lam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 135812    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Mark Hahnenberg
Reported 2014-08-08 18:21:22 PDT
Fix on its way...
Attachments
Patch (10.22 KB, patch)
2014-08-08 18:23 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (8.33 KB, patch)
2014-08-08 23:00 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2014-08-08 18:23:45 PDT
Created attachment 236329 [details] Patch
Mark Hahnenberg
Comment 2 2014-08-08 23:00:43 PDT
Created attachment 236331 [details] Patch
Geoffrey Garen
Comment 3 2014-08-11 11:25:48 PDT
Comment on attachment 236331 [details] Patch r=me
WebKit Commit Bot
Comment 4 2014-08-11 12:00:04 PDT
Comment on attachment 236331 [details] Patch Clearing flags on attachment: 236331 Committed r172401: <http://trac.webkit.org/changeset/172401>
WebKit Commit Bot
Comment 5 2014-08-11 12:00:07 PDT
All reviewed patches have been landed. Closing bug.
Mark Lam
Comment 7 2014-08-11 12:49:40 PDT
Looks like this is not just a 32-bit issue: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/7945
WebKit Commit Bot
Comment 8 2014-08-11 12:56:51 PDT
Re-opened since this is blocked by bug 135812
Mark Lam
Comment 9 2014-08-11 13:17:10 PDT
Looks like there's a bug in the test. "for (var p in a) {" should be "for (var p in b) {". Currently re-testing before re-landing.
Geoffrey Garen
Comment 10 2014-08-11 14:47:05 PDT
<rdar://problem/17793974>
Geoffrey Garen
Comment 11 2014-08-11 14:47:19 PDT
Sorry, ignore that Radar link.
Mark Lam
Comment 12 2014-08-11 15:01:09 PDT
Patch re-landed in r172413: <http://trac.webkit.org/r172413>.
Filip Pizlo
Comment 13 2014-08-18 18:32:35 PDT
This was a 50% regression on string-fasta.
Note You need to log in before you can comment on or make changes to this bug.